[go_router] change fix_data.yaml uris to be absolute to fix lints

packages/go_router/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 7.0.1
+
+- Fixes the `dart fix --apply` command not working
+
 ## 7.0.0
 
 - **BREAKING CHANGE**:

packages/go_router/lib/fix_data.yaml

@@ -21,7 +21,7 @@ transforms:
     date: 2023-04-24
     bulkApply: true
     element:
-      uris: [ 'go_router.dart' ]
+      uris: [ 'go_router.dart', 'package:go_router/go_router.dart' ]
       method: 'replaceNamed'
       inClass: 'GoRouter'
     changes:
@@ -35,7 +35,7 @@ transforms:
     date: 2023-04-24
     bulkApply: true
     element:
-      uris: [ 'go_router.dart' ]
+      uris: [ 'go_router.dart', 'package:go_router/go_router.dart' ]
       method: 'pushReplacementNamed'
       inClass: 'GoRouter'
     changes:
@@ -50,7 +50,7 @@ transforms:
     date: 2023-04-24
     bulkApply: true
     element:
-      uris: [ 'go_router.dart' ]
+      uris: [ 'go_router.dart', 'package:go_router/go_router.dart' ]
       method: 'pushNamed'
       inClass: 'GoRouter'
     changes:
@@ -65,7 +65,7 @@ transforms:
     date: 2023-04-24
     bulkApply: true
     element:
-      uris: [ 'go_router.dart' ]
+      uris: [ 'go_router.dart', 'package:go_router/go_router.dart' ]
       method: 'goNamed'
       inClass: 'GoRouter'
     changes:
@@ -80,7 +80,7 @@ transforms:
     date: 2023-04-24
     bulkApply: true
     element:
-      uris: [ 'go_router.dart' ]
+      uris: [ 'go_router.dart', 'package:go_router/go_router.dart' ]
       method: 'namedLocation'
       inClass: 'GoRouter'
     changes:
@@ -95,7 +95,7 @@ transforms:
     date: 2023-04-24
     bulkApply: true
     element:
-      uris: [ 'go_router.dart' ]
+      uris: [ 'go_router.dart', 'package:go_router/go_router.dart' ]
       method: 'namedLocation'
       inClass: 'GoRouterState'
     changes:
@@ -110,7 +110,7 @@ transforms:
     date: 2023-04-24
     bulkApply: true
     element:
-      uris: [ 'go_router.dart' ]
+      uris: [ 'go_router.dart', 'package:go_router/go_router.dart' ]
       field: 'queryParams'
       inClass: 'GoRouterState'
     changes:
@@ -121,7 +121,7 @@ transforms:
     date: 2023-04-24
     bulkApply: true
     element:
-      uris: [ 'go_router.dart' ]
+      uris: [ 'go_router.dart', 'package:go_router/go_router.dart' ]
       field: 'fullpath'
       inClass: 'GoRouterState'
     changes:
@@ -132,7 +132,7 @@ transforms:
     date: 2023-04-24
     bulkApply: true
     element:
-      uris: [ 'go_router.dart' ]
+      uris: [ 'go_router.dart', 'package:go_router/go_router.dart' ]
       field: 'params'
       inClass: 'GoRouterState'
     changes:
@@ -143,7 +143,7 @@ transforms:
     date: 2023-04-24
     bulkApply: true
     element:
-      uris: [ 'go_router.dart' ]
+      uris: [ 'go_router.dart', 'package:go_router/go_router.dart' ]
       field: 'subloc'
       inClass: 'GoRouterState'
     changes:

packages/go_router/pubspec.yaml

@@ -1,7 +1,7 @@
 name: go_router
 description: A declarative router for Flutter based on Navigation 2 supporting
   deep linking, data-driven routes and more
-version: 7.0.0
+version: 7.0.1
 repository: https://github.com/flutter/packages/tree/main/packages/go_router
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router%22
 
@@ -21,4 +21,6 @@ dependencies:
 dev_dependencies:
   flutter_test:
     sdk: flutter
+  io: ^1.0.4
   path: ^1.8.2
+  yaml_edit: ^2.1.0

packages/go_router/test_fixes/pubspec.yaml

@@ -0,0 +1,13 @@
+name: test_fixes
+publish_to: "none"
+version: 1.0.0+1
+
+environment:
+  sdk: ">=2.18.0 <4.0.0"
+  flutter: ">=3.3.0"
+
+dependencies:
+  flutter:
+    sdk: flutter
+  go_router:
+    path: ../

packages/go_router/tool/run_tests.dart

@@ -9,27 +9,86 @@
 // ignore_for_file: avoid_print
 
 import 'dart:io';
+import 'package:io/io.dart' as io;
 import 'package:path/path.dart' as p;
+import 'package:yaml_edit/yaml_edit.dart';
 
 Future<void> main(List<String> args) async {
-  if (!Platform.isMacOS) {
-    print('This test can only be run on macOS.');
+  if (!Platform.isMacOS /* && !Platform.isWindows*/) {
+    print('This test can only be run on macOS' /*' or windows.'*/);
     exit(0);
   }
+  final p.Context ctx = p.context;
   final Directory packageRoot =
-      Directory(p.dirname(Platform.script.path)).parent;
+      Directory(ctx.dirname(_ensureTrimLeadingSeparator(Platform.script.path)))
+          .parent;
+
+  //copy from go_router/test_fixes to temp directory
+  final Directory testFixesTargetDir = await Directory.systemTemp.createTemp();
+
+  await _prepareTemplate(
+    ctx: ctx,
+    testFixesDir: ctx.join(packageRoot.path, 'test_fixes'),
+    testFixesTargetDir: testFixesTargetDir.path,
+    //Switching this to true, will depend on go_router v7.0.0, which will fail the golden test
+    testBadVersion: false,
+  );
+  final int pubGet = await _runProcess(
+    'dart',
+    <String>[
+      'pub',
+      'upgrade',
+    ],
+    workingDirectory: testFixesTargetDir.path,
+  );
+  if (pubGet != 0) {
+    exit(pubGet);
+  }
   final int status = await _runProcess(
     'dart',
     <String>[
       'fix',
       '--compare-to-golden',
     ],
-    workingDirectory: p.join(packageRoot.path, 'test_fixes'),
+    workingDirectory: testFixesTargetDir.path,
   );
 
   exit(status);
 }
 
+Future<void> _prepareTemplate({
+  required String testFixesDir,
+  required String testFixesTargetDir,
+  required p.Context ctx,
+  required bool testBadVersion,
+}) async {
+  await io.copyPath(testFixesDir, testFixesTargetDir);
+
+  final String pubspecYamlPath = ctx.join(testFixesTargetDir, 'pubspec.yaml');
+  final File targetPubspecPath = File(pubspecYamlPath);
+
+  final YamlEditor editor = YamlEditor(await targetPubspecPath.readAsString());
+  if (testBadVersion) {
+    editor.update(<String>['dependencies', 'go_router'], '7.0.0');
+  } else {
+    editor.update(
+      <String>['dependencies', 'go_router', 'path'],
+      ctx.dirname(testFixesDir),
+    );
+  }
+  final String newYaml = editor.toString();
+  await targetPubspecPath.writeAsString(newYaml);
+}
+
+String _ensureTrimLeadingSeparator(String path) {
+  if (Platform.isWindows) {
+    if (path.startsWith('/')) {
+      return path.substring(1);
+    }
+  }
+  return path;
+}
+
 Future<Process> _streamOutput(Future<Process> processFuture) async {
   final Process process = await processFuture;
   stdout.addStream(process.stdout);