[in_app_pur]: Bump com.android.billingclient:billing from 5.2.0 to 6.0.0 in /packages/in_app_purchase/in_app_purchase_android/android #3988
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
Bumps com.android.billingclient:billing from 5.2.0 to 6.0.0. --- updated-dependencies: - dependency-name: com.android.billingclient:billing dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/gradle/packages/in_app_purchase/in_app_purchase_android/android/com.android.billingclient-billing-6.0.0
branch
from
f8c5ea5 to
d1d189f
Compare
…n_app_purchase_android/android/com.android.billingclient-billing-6.0.0
|
@gmackall It looks like we may be able to do this with some temporary deprecation suppression, and file an issue for resolving those later? We'd have to see if the tests all pass once we do that. |
…n_app_purchase_android/android/com.android.billingclient-billing-6.0.0
|
@stuartmorgan do you want to do a second review on this given that its not a true dependabot PR (it is largely edited)? The changes I made were to suppress the warnings in MethodCallHandlerImpl.java, as well as the corresponding test, with annotations. I also removed the import and instead used the fully qualified class name, because I didn't see another example of suppressing a warning on an import (hence removing the import). Let me know if there is a better way! I also filed the issue to remove usages of the deprecated class. |
That's the only way to do it that I could find previously, unfortunately. |
| @@ -131,6 +130,7 @@ void onDetachedFromActivity() { | |||
| } | |||
|
|
|||
| @Override | |||
| @SuppressWarnings(value = "deprecation") | |||
There was a problem hiding this comment.
Generally we extract deprecated code paths to a minimal helper method that we can mark as deprecated, rather than making a whole large method, since the latter will hide future issues.
This also seems like something we should have an issue and TODO for migrating to the new API.
| @@ -222,6 +223,7 @@ private void queryProductDetailsAsync( | |||
| }); | |||
| } | |||
|
|
|||
| @SuppressWarnings(value = "deprecation") | |||
|
A newer version of com.android.billingclient:billing exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
Closing as the conflicts here have built up, takeover in: #4390. I addressed the creation of TODO with issue in the new PR. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/gradle/packages/in_app_purchase/in_app_purchase_android/android/com.android.billingclient-billing-6.0.0
branch
… 5.2.0 to 6.0.0. (#4390) Takeover of #3988 Conflicts had built up and it required some additional changes so I figured it would be easier to just make my own new branch to fix. Changes from last PR 1. I made the particular ProrationMode enum value we were using a constant and put the deprecation suppression on that constant. 2. I made a helper to wrap the other deprecated method (`setReplaceProrationMode`). 3. Added todos with links to the issue for replacing the deprecated classes/methods.
Bumps com.android.billingclient:billing from 5.2.0 to 6.0.0.
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)