Skip to content

[ci] Allow simctl shutdown to fail #4024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented May 16, 2023

Since adding set -e, this script sometimes fails with:

An error was encountered processing the command (domain=com.apple.CoreSimulator.SimError, code=405):
Unable to shutdown device in current state: Shutdown

Allow shutdown to fail; if something is really wrong that prevents cleanup, deleting the device should still fail, so this should be harmless.

Since adding `set -e`, this script sometimes fails with:

```
An error was encountered processing the command (domain=com.apple.CoreSimulator.SimError, code=405):
Unable to shutdown device in current state: Shutdown
```

Allow shutdown to fail; if something is really wrong that prevents
cleaunp, deleting the device should still fail, so this should be
harmless.
@stuartmorgan-g stuartmorgan-g requested a review from ditman May 16, 2023 19:16
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's give this a shot!

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2023
@auto-submit auto-submit bot merged commit eabaacc into flutter:main May 16, 2023
@stuartmorgan-g stuartmorgan-g deleted the ci-allow-simulator-shutdown-failure branch May 16, 2023 20:19
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 17, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 17, 2023
flutter/packages@b971830...5c69914

2023-05-17 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 2.18.5 to 2.18.6 in /packages/video_player/video_player_android/android (flutter/packages#3770)
2023-05-17 [email protected] [in_app_purchase] Fully migrate to BillingClient V5 (flutter/packages#3752)
2023-05-17 [email protected] [ci] Re-enable Windows repo tool tests (flutter/packages#4007)
2023-05-16 [email protected] [ci] Allow simctl shutdown to fail (flutter/packages#4024)
2023-05-16 [email protected] [ci] Move Linux repo tool tests to LUCI (flutter/packages#4006)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
flutter/packages@b971830...5c69914

2023-05-17 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 2.18.5 to 2.18.6 in /packages/video_player/video_player_android/android (flutter/packages#3770)
2023-05-17 [email protected] [in_app_purchase] Fully migrate to BillingClient V5 (flutter/packages#3752)
2023-05-17 [email protected] [ci] Re-enable Windows repo tool tests (flutter/packages#4007)
2023-05-16 [email protected] [ci] Allow simctl shutdown to fail (flutter/packages#4024)
2023-05-16 [email protected] [ci] Move Linux repo tool tests to LUCI (flutter/packages#4006)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
Since adding `set -e`, this script sometimes fails with:

```
An error was encountered processing the command (domain=com.apple.CoreSimulator.SimError, code=405):
Unable to shutdown device in current state: Shutdown
```

Allow shutdown to fail; if something is really wrong that prevents cleanup, deleting the device should still fail, so this should be harmless.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants