Skip to content

[in_app_purchases] Fix mismatching method signature strings #4040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2023
Merged

[in_app_purchases] Fix mismatching method signature strings #4040

merged 2 commits into from
May 22, 2023

Conversation

JeroenWeener
Copy link
Contributor

@JeroenWeener JeroenWeener commented May 19, 2023 •
edited
Loading

In the upgrade to billing client v5 in #3752, some method signature strings on the Java side were updated. Unfortunately, as the Dart side was not updated. This mismatch broke the interaction between the Dart and native Android code through the method channels.

This PR updates the strings on the Dart side so the method invocation work correctly again.

This is a follow-up to

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@JeroenWeener JeroenWeener requested a review from gmackall as a code owner May 19, 2023 08:36
@JeroenWeener JeroenWeener force-pushed the in-app-purchases/fix-v5-bugs branch from 13ad1d7 to bd3feb1 Compare May 22, 2023 08:10
stuartmorgan-g
stuartmorgan-g approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We should try to move this to near the top of our Pigeon conversion list; this is at least the second time in recent memory we've had string mismatches in this package.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label May 22, 2023
@auto-submit auto-submit bot merged commit 83959fb into flutter:main May 22, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2023
@engine-flutter-autoroll
83959fb [in_app_purchases] Fix mismatching method signature strings (f…
443f09d 
…lutter/packages#4040)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 22, 2023
@engine-flutter-autoroll
Roll Packages from 1e214d7 to 83959fb (9 revisions) (#127322)
5b0615c 
flutter/packages@1e214d7...83959fb

2023-05-22 [email protected] [in_app_purchases] Fix mismatching method signature strings (flutter/packages#4040)
2023-05-22 [email protected] [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)
2023-05-22 [email protected] [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)
2023-05-22 [email protected] [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)
2023-05-22 [email protected] Roll Flutter from 077d644 to ab57304 (18 revisions) (flutter/packages#4051)
2023-05-19 [email protected] Roll Flutter from 5ae6438 to 077d644 (23 revisions) (flutter/packages#4043)
2023-05-19 [email protected] [local_auth] Migrate iOS to Pigeon (flutter/packages#3974)
2023-05-19 [email protected] [go_router] fix context extension for replaceNamed (flutter/packages#3927)
2023-05-19 [email protected] [image_picker] Fix crash due to `SecurityException` (flutter/packages#4004)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
sybrands-place pushed a commit to sybrands-place/packages that referenced this pull request May 23, 2023
Merge branch 'main' into webview_patchedv5
a3ba9c3 
* main: (104 commits)
  [various] Remove unnecessary null checks (flutter#4060)
  [ci] Add a legacy Android build-all test (flutter#4005)
  Roll Flutter from ab57304 to 3437189 (5 revisions) (flutter#4062)
  [go_router] Nested stateful navigation with ShellRoute (flutter#2650)
  [go_router] Nested stateful navigation with ShellRoute (flutter#2650)
  [go_router] Nested stateful navigation with ShellRoute (flutter#2650)
  [in_app_purchases] Fix mismatching method signature strings (flutter#4040)
  [go_router] Nested stateful navigation with ShellRoute (flutter#2650)
  [go_router] Nested stateful navigation with ShellRoute (flutter#2650)
  [go_router] Nested stateful navigation with ShellRoute (flutter#2650)
  Roll Flutter from 077d644 to ab57304 (18 revisions) (flutter#4051)
  Roll Flutter from 5ae6438 to 077d644 (23 revisions) (flutter#4043)
  [local_auth] Migrate iOS to Pigeon (flutter#3974)
  [go_router] fix context extension for replaceNamed (flutter#3927)
  [image_picker] Fix crash due to `SecurityException` (flutter#4004)
  Roll Flutter from d0d1feb to 5ae6438 (42 revisions) (flutter#4038)
  [ci] Lower iOS LUCI timeouts (flutter#4035)
  [ci] Increase Android sharding (flutter#4029)
  [flutter_plugin_android_lifecycle] Fix lints (flutter#4030)
  [rfw] Fix a typo in the API documentation (flutter#4023)
  ...
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@engine-flutter-autoroll
Roll Packages from 1e214d7 to 83959fb (9 revisions) (flutter#127322)
8f54016 
flutter/packages@1e214d7...83959fb

2023-05-22 [email protected] [in_app_purchases] Fix mismatching method signature strings (flutter/packages#4040)
2023-05-22 [email protected] [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)
2023-05-22 [email protected] [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)
2023-05-22 [email protected] [go_router] Nested stateful navigation with ShellRoute (flutter/packages#2650)
2023-05-22 [email protected] Roll Flutter from 077d644 to ab57304 (18 revisions) (flutter/packages#4051)
2023-05-19 [email protected] Roll Flutter from 5ae6438 to 077d644 (23 revisions) (flutter/packages#4043)
2023-05-19 [email protected] [local_auth] Migrate iOS to Pigeon (flutter/packages#3974)
2023-05-19 [email protected] [go_router] fix context extension for replaceNamed (flutter/packages#3927)
2023-05-19 [email protected] [image_picker] Fix crash due to `SecurityException` (flutter/packages#4004)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@JeroenWeener @nploi
[in_app_purchases] Fix mismatching method signature strings (flutter#…
c23fa71 
…4040)

In the upgrade to billing client v5 in flutter#3752, some method signature strings on the Java side were updated. Unfortunately, as the Dart side was not updated. This mismatch broke the interaction between the Dart and native Android code through the method channels.

This PR updates the strings on the Dart side so the method invocation work correctly again.

This is a follow-up to
- flutter/flutter#110909
- flutter/flutter#107370
- flutter/flutter#114265
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@reidbaker reidbaker reidbaker approved these changes

@gmackall gmackall Awaiting requested review from gmackall gmackall is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

@tarrinneal tarrinneal Awaiting requested review from tarrinneal

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: in_app_purchase platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeroenWeener @stuartmorgan-g @reidbaker