Skip to content

[webview_flutter] Support for handling basic authentication requests #4140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 31 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
517e9d4
Implement http basic auth
JeroenWeener Aug 10, 2023
967879b
Apply feedback
JeroenWeener Aug 28, 2023
c8624c0
Create HttpAuthHandlerTest.java
JeroenWeener Aug 29, 2023
4f3574d
Format java files
JeroenWeener Aug 29, 2023
1e7f785
Regenerate build_runner files
JeroenWeener Aug 29, 2023
131bc56
Implement feedback
JeroenWeener Sep 11, 2023
bc01be4
Remove redundant key in `Info.plist`
JeroenWeener Sep 11, 2023
67aa00e
Update example apps
JeroenWeener Sep 11, 2023
32496d0
Implement http basic auth
JeroenWeener Aug 10, 2023
aeb8708
Apply feedback
JeroenWeener Aug 28, 2023
fffc4c7
Create HttpAuthHandlerTest.java
JeroenWeener Aug 29, 2023
b455040
Format java files
JeroenWeener Aug 29, 2023
2aa9bfe
Regenerate build_runner files
JeroenWeener Aug 29, 2023
db286ba
Implement feedback
JeroenWeener Sep 11, 2023
467feb3
Remove redundant key in `Info.plist`
JeroenWeener Sep 11, 2023
dad8ae6
Update example apps
JeroenWeener Sep 11, 2023
6f3d802
Merge branch 'webview-auth-request' of https://github.com/andreisas06…
JeroenWeener Nov 1, 2023
0fef591
Add platform interface dev dependency to example
JeroenWeener Nov 1, 2023
b2a4fbb
Merge branch 'main' into webview-auth-request
JeroenWeener Nov 1, 2023
ce35d9b
Update packages/webview_flutter/webview_flutter_platform_interface/li…
bparrishMines Nov 8, 2023
fc32898
Merge branch 'main' of github.com:flutter/packages into webview-auth-…
bparrishMines Nov 8, 2023
4673e65
Merge branch 'webview-auth-request' of github.com:andreisas06/package…
bparrishMines Nov 8, 2023
580521a
Fix some lints, errros and call on errors
bparrishMines Nov 8, 2023
d1f305b
fix lints
bparrishMines Nov 8, 2023
a3f74be
fix tests
bparrishMines Nov 8, 2023
ed3798f
add onProceed and onCancel back
bparrishMines Nov 8, 2023
154c1f8
dont require realm to be nonnull
bparrishMines Nov 8, 2023
3c61dbc
add line back
bparrishMines Nov 8, 2023
7cf0d7e
Merge remote-tracking branch 'upstream/main' into webview-auth-request
JeroenWeener Nov 21, 2023
a21f29a
Update changelogs
JeroenWeener Nov 21, 2023
8f7603a
Merge main
JeroenWeener Dec 20, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
17 changes: 2 additions & 15 deletions .ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ platform_properties:
[
{"dependency": "ruby", "version": "ruby_3.1-pod_1.13"}
]
os: Mac-12|Mac-13
os: "Mac-12"
device_type: none
cpu: arm64
# TODO(vashworth): Remove specific toolchain_ver once https://github.com/flutter/flutter/issues/138109 is resolved.
Expand All @@ -101,7 +101,7 @@ platform_properties:
[
{"dependency": "ruby", "version": "ruby_3.1-pod_1.13"}
]
os: Mac-12|Mac-13
os: "Mac-12"
device_type: none
cpu: x86
# TODO(vashworth): Remove specific toolchain_ver once https://github.com/flutter/flutter/issues/138109 is resolved.
Expand Down Expand Up @@ -1098,19 +1098,6 @@ targets:
- name: Windows_x64 windows-build_all_packages stable
recipe: packages/packages
timeout: 30
properties:
target_file: windows_build_all_packages.yaml
channel: stable
version_file: flutter_stable.version
dependencies: >
[
{"dependency": "vs_build", "version": "version:vs2019"}
]

- name: Windows_arm64 windows-build_all_packages stable
recipe: packages/packages
timeout: 30
bringup: true
properties:
add_recipes_cq: "true"
target_file: windows_build_all_packages.yaml
Expand Down
2 changes: 1 addition & 1 deletion .ci/flutter_master.version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0eb788134051dd62c28d49cda7ea396f8750e18f
9c9e0617b1498104b1c4128d8729a7815254f533
2 changes: 1 addition & 1 deletion .ci/flutter_stable.version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2e9cb0aa71a386a91f73f7088d115c0d96654829
db7ef5bf9f59442b0e200a90587e8fa5e0c6336a
10 changes: 0 additions & 10 deletions .ci/scripts/update_pods.sh

This file was deleted.

3 changes: 0 additions & 3 deletions .ci/targets/macos_check_podspecs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: update pods repo
script: .ci/scripts/update_pods.sh
infra_step: true # Note infra steps failing prevents "always" from running.
- name: validate iOS and macOS podspecs
script: script/tool_runner.sh
args: ["podspec-check"]
204 changes: 55 additions & 149 deletions .github/labeler.yml
Original file line number Diff line number Diff line change
@@ -1,243 +1,149 @@
'p: animations':
- changed-files:
- any-glob-to-any-file:
- packages/animations/**/*
- packages/animations/**/*

'p: camera':
- changed-files:
- any-glob-to-any-file:
- packages/camera/**/*
- packages/camera/**/*

'p: cross_file':
- changed-files:
- any-glob-to-any-file:
- packages/cross_file/**/*
- packages/cross_file/**/*

'p: css_colors':
- changed-files:
- any-glob-to-any-file:
- packages/css_colors/**/*
- packages/css_colors/**/*

'p: cupertino_icons':
- changed-files:
- any-glob-to-any-file:
- third_party/packages/cupertino_icons/**/*
- third_party/packages/cupertino_icons/**/*

'p: dynamic_layouts':
- changed-files:
- any-glob-to-any-file:
- packages/dynamic_layouts/**/*
- packages/dynamic_layouts/**/*

'p: espresso':
- changed-files:
- any-glob-to-any-file:
- packages/espresso/**/*
- packages/espresso/**/*

'p: extension_google_sign_in_as_googleapis_auth':
- changed-files:
- any-glob-to-any-file:
- packages/extension_google_sign_in_as_googleapis_auth/**/*
- packages/extension_google_sign_in_as_googleapis_auth/**/*

'p: file_selector':
- changed-files:
- any-glob-to-any-file:
- packages/file_selector/**/*
- packages/file_selector/**/*

'p: flutter_adaptive_scaffold':
- changed-files:
- any-glob-to-any-file:
- packages/flutter_adaptive_scaffold/**/*
- packages/flutter_adaptive_scaffold/**/*

'p: flutter_image':
- changed-files:
- any-glob-to-any-file:
- packages/flutter_image/**/*
- packages/flutter_image/**/*

'p: flutter_lints':
- changed-files:
- any-glob-to-any-file:
- packages/flutter_lints/**/*
- packages/flutter_lints/**/*

'p: flutter_markdown':
- changed-files:
- any-glob-to-any-file:
- packages/flutter_markdown/**/*
- packages/flutter_markdown/**/*

'p: flutter_migrate':
- changed-files:
- any-glob-to-any-file:
- packages/flutter_migrate/**/*
- packages/flutter_migrate/**/*

'p: flutter_plugin_android_lifecycle':
- changed-files:
- any-glob-to-any-file:
- packages/flutter_plugin_android_lifecycle/**/*
- packages/flutter_plugin_android_lifecycle/**/*

'p: flutter_template_images':
- changed-files:
- any-glob-to-any-file:
- packages/flutter_template_images/**/*
- packages/flutter_template_images/**/*

'p: go_router':
- changed-files:
- any-glob-to-any-file:
- packages/go_router/**/*
- packages/go_router/**/*

'p: go_router_builder':
- changed-files:
- any-glob-to-any-file:
- packages/go_router_builder/**/*
- packages/go_router_builder/**/*

'p: google_identity_services':
- changed-files:
- any-glob-to-any-file:
- packages/google_indentity_services_web/**
- packages/google_indentity_services_web/**

'p: google_maps_flutter':
- changed-files:
- any-glob-to-any-file:
- packages/google_maps_flutter/**/*
- packages/google_maps_flutter/**/*

'p: google_sign_in':
- changed-files:
- any-glob-to-any-file:
- packages/google_sign_in/**/*
- packages/google_sign_in/**/*

'p: image_picker':
- changed-files:
- any-glob-to-any-file:
- packages/image_picker/**/*
- packages/image_picker/**/*

'p: in_app_purchase':
- changed-files:
- any-glob-to-any-file:
- packages/in_app_purchase/**/*
- packages/in_app_purchase/**/*

'p: ios_platform_images':
- changed-files:
- any-glob-to-any-file:
- packages/ios_platform_images/**/*
- packages/ios_platform_images/**/*

'p: local_auth':
- changed-files:
- any-glob-to-any-file:
- packages/local_auth/**/*
- packages/local_auth/**/*

'p: metrics_center':
- changed-files:
- any-glob-to-any-file:
- packages/metrics_center/**/*
- packages/metrics_center/**/*

'p: multicast_dns':
- changed-files:
- any-glob-to-any-file:
- packages/multicast_dns/**/*
- packages/multicast_dns/**/*

'p: palette_generator':
- changed-files:
- any-glob-to-any-file:
- packages/palette_generator/**/*
- packages/palette_generator/**/*

'p: path_provider':
- changed-files:
- any-glob-to-any-file:
- packages/path_provider/**/*
- packages/path_provider/**/*

'p: pigeon':
- changed-files:
- any-glob-to-any-file:
- packages/pigeon/**/*
- packages/pigeon/**/*

'p: plugin_platform_interface':
- changed-files:
- any-glob-to-any-file:
- packages/plugin_platform_interface/**/*
- packages/plugin_platform_interface/**/*

'p: pointer_interceptor':
- changed-files:
- any-glob-to-any-file:
- packages/pointer_interceptor/**/*
- packages/pointer_interceptor/**/*

'p: quick_actions':
- changed-files:
- any-glob-to-any-file:
- packages/quick_actions/**/*
- packages/quick_actions/**/*

'p: rfw':
- changed-files:
- any-glob-to-any-file:
- packages/rfw/**/*
- packages/rfw/**/*

'p: shared_preferences':
- changed-files:
- any-glob-to-any-file:
- packages/shared_preferences/**/*
- packages/shared_preferences/**/*

'p: standard_message_codec':
- changed-files:
- any-glob-to-any-file:
- packages/standard_message_codec/**/*
- packages/standard_message_codec/**/*

'p: url_launcher':
- changed-files:
- any-glob-to-any-file:
- packages/url_launcher/**/*
- packages/url_launcher/**/*

'p: video_player':
- changed-files:
- any-glob-to-any-file:
- packages/video_player/**/*
- packages/video_player/**/*

'p: web_benchmarks':
- changed-files:
- any-glob-to-any-file:
- packages/web_benchmarks/**/*
- packages/web_benchmarks/**/*

'p: webview_flutter':
- changed-files:
- any-glob-to-any-file:
- packages/webview_flutter/**/*
- packages/webview_flutter/**/*

'p: xdg_directories':
- changed-files:
- any-glob-to-any-file:
- packages/xdg_directories/**/*
- packages/xdg_directories/**/*

'platform-android':
- changed-files:
- any-glob-to-any-file:
- packages/*/*_android/**/*
- packages/**/android/**/*
- packages/*/*_android/**/*
- packages/**/android/**/*

'platform-ios':
- changed-files:
- any-glob-to-any-file:
- packages/*/*_ios/**/*
- packages/*/*_storekit/**/*
- packages/*/*_wkwebview/**/*
- packages/**/ios/**/*
- packages/*/*_ios/**/*
- packages/*/*_storekit/**/*
- packages/*/*_wkwebview/**/*
- packages/**/ios/**/*

'platform-linux':
- changed-files:
- any-glob-to-any-file:
- packages/*/*_linux/**/*
- packages/**/linux/**/*
- packages/*/*_linux/**/*
- packages/**/linux/**/*

'platform-macos':
- changed-files:
- any-glob-to-any-file:
- packages/*/*_macos/**/*
- packages/**/macos/**/*
- packages/*/*_macos/**/*
- packages/**/macos/**/*

'platform-web':
- changed-files:
- any-glob-to-any-file:
- packages/*/*_web/**/*
- packages/**/web/**/*
- packages/*/*_web/**/*
- packages/**/web/**/*

'platform-windows':
- changed-files:
- any-glob-to-any-file:
- packages/*/*_windows/**/*
- packages/**/windows/**/*
- packages/*/*_windows/**/*
- packages/**/windows/**/*

2 changes: 1 addition & 1 deletion .github/workflows/pull_request_label.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
pull-requests: write
runs-on: ubuntu-latest
steps:
- uses: actions/labeler@8558fd74291d67161a8a78ce36a881fa63b766a9
- uses: actions/labeler@ac9175f8a1f3625fd0d4fb234536d26811351594
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"
sync-labels: true
2 changes: 1 addition & 1 deletion .github/workflows/scorecards-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,6 @@ jobs:

# Upload the results to GitHub's code scanning dashboard.
- name: "Upload to code-scanning"
uses: github/codeql-action/upload-sarif@b374143c1149a9115d881581d29b8390bbcbb59c # v1.0.26
uses: github/codeql-action/upload-sarif@74483a38d39275f33fcff5f35b679b5ca4a26a99 # v1.0.26
with:
sarif_file: results.sarif
Loading