[google_maps_flutter_platform_interface] Add support for cloud-based map styling #4141
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
The changes here need testing in map_configuration_test.dart.
It looks like currently we're only testing diff in general, but we should test the others as well. (No need to backfill tests all the existing properties in equality, empty, etc., but we should add them for the new one.)
Added test cases to diffs. |
|
Looks like this is ready to land and was just never submitted, so I'm going to add the |
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/packages, pr: 4141, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.
|
|
Unclear why this needs a second review 🤷🏻 |
| indoorViewEnabled: false, | ||
| trafficEnabled: false, | ||
| buildingsEnabled: false, | ||
| cloudMapId: _kCloudMapId); |
There was a problem hiding this comment.
nit: add a trailing comma here.
tarrinneal
added
the
autosubmit
…d-based map styling (flutter/packages#4141)
…d-based map styling (flutter/packages#4141)
…d-based map styling (flutter/packages#4141)
flutter/packages@aa1eace...369ee7e 2023-07-14 [email protected] [Tool] New tool to download android dependencies (flutter/packages#4408) 2023-07-14 [email protected] [video_player] added iOS exception on incorrect asset path (flutter/packages#4318) 2023-07-14 [email protected] [google_maps_flutter_platform_interface] Add support for cloud-based map styling (flutter/packages#4141) 2023-07-14 [email protected] [webview_flutter] Adds support for receiving a url with WebResourceError (flutter/packages#3884) 2023-07-14 [email protected] [xdg_directories] Remove `process` dependency (flutter/packages#4460) 2023-07-13 [email protected] [various] Update Pigeon in Swift plugins (flutter/packages#4461) 2023-07-13 [email protected] Roll Flutter from 544d30d to c40173f (10 revisions) (flutter/packages#4457) 2023-07-13 [email protected] Roll Flutter (stable) from 796c8ef to f468f33 (2 revisions) (flutter/packages#4456) 2023-07-13 [email protected] Fix Router Config Issues #4300 (go_router_builder/example) (flutter/packages#4369) 2023-07-13 [email protected] [webview_flutter_platform_interface] Adds url to `WebResourceError` (flutter/packages#4439) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@aa1eace...369ee7e 2023-07-14 [email protected] [Tool] New tool to download android dependencies (flutter/packages#4408) 2023-07-14 [email protected] [video_player] added iOS exception on incorrect asset path (flutter/packages#4318) 2023-07-14 [email protected] [google_maps_flutter_platform_interface] Add support for cloud-based map styling (flutter/packages#4141) 2023-07-14 [email protected] [webview_flutter] Adds support for receiving a url with WebResourceError (flutter/packages#3884) 2023-07-14 [email protected] [xdg_directories] Remove `process` dependency (flutter/packages#4460) 2023-07-13 [email protected] [various] Update Pigeon in Swift plugins (flutter/packages#4461) 2023-07-13 [email protected] Roll Flutter from 544d30d to c40173f (10 revisions) (flutter/packages#4457) 2023-07-13 [email protected] Roll Flutter (stable) from 796c8ef to f468f33 (2 revisions) (flutter/packages#4456) 2023-07-13 [email protected] Fix Router Config Issues flutter#4300 (go_router_builder/example) (flutter/packages#4369) 2023-07-13 [email protected] [webview_flutter_platform_interface] Adds url to `WebResourceError` (flutter/packages#4439) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR is sub-PR splitted out from the #3682
containing only the platform_interface package changes.
Related to issue flutter/flutter#67631
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.