-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[tool] Update Dart SDK version #4402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the tool only needs to support back to Flutter 3.3 (the oldest version we still run CI with), this updates the tool to the corresponding minimum Dart version. This allows the use of `super` parameters, so `dart fix --apply` was run to convert them all (and remove all the includes that were only needed for setting default values). Also opportunistically cleans up a bunch of unnecessry very old `dart:async` includes.
tarrinneal
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks "super." to me!
auto label is removed for flutter/packages, pr: 4402, due to Pull request flutter/packages/4402 is not in a mergeable state. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 10, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 10, 2023
flutter/packages@b61eea1...4469c5e 2023-07-08 [email protected] Roll Flutter from d55a7d8 to 65ff3cb (21 revisions) (flutter/packages#4413) 2023-07-08 [email protected] [tool] Update Dart SDK version (flutter/packages#4402) 2023-07-08 [email protected] [url_lancher] Don't use `canLaunchUrl` in Link (flutter/packages#4400) 2023-07-08 [email protected] Remove unused autosubmit configuration file (flutter/packages#4410) 2023-07-07 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.5.0 to 1.6.0 in /packages/file_selector/file_selector_android/android (flutter/packages#4312) 2023-07-07 [email protected] Roll Flutter from bc49cd1 to d55a7d8 (17 revisions) (flutter/packages#4403) 2023-07-07 [email protected] [shared_preferences] Variable binding in a condition requires an initializer fix (flutter/packages#4407) 2023-07-07 [email protected] [go_router] implemented helpers for StatefulShellRoute (flutter/packages#4228) 2023-07-07 [email protected] [in_app_purchase_android] Bump com.android.billingclient:billing from 5.2.0 to 6.0.0. (flutter/packages#4390) 2023-07-07 [email protected] [tool] Use 'flutter pub get' for Flutter packages (flutter/packages#4397) 2023-07-07 [email protected] [ci] Enable LUCI stable custom Linux tests (flutter/packages#4404) 2023-07-07 [email protected] [tool] Fix --current-package for app-facing packages (flutter/packages#4399) 2023-07-07 [email protected] [ci] Switch some tests to LUCI (flutter/packages#4395) 2023-07-07 [email protected] [flutter_markdown] Pass parent TextStyle down to MarkdownElementBuilder.visitElementAfter (flutter/packages#4393) 2023-07-07 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.3.3 to 2.20.3 (flutter/packages#4394) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
11 tasks
11 tasks
gbtb16
pushed a commit
to gbtb16/flutter
that referenced
this pull request
Nov 6, 2023
flutter/packages@b61eea1...4469c5e 2023-07-08 [email protected] Roll Flutter from d55a7d8 to 65ff3cb (21 revisions) (flutter/packages#4413) 2023-07-08 [email protected] [tool] Update Dart SDK version (flutter/packages#4402) 2023-07-08 [email protected] [url_lancher] Don't use `canLaunchUrl` in Link (flutter/packages#4400) 2023-07-08 [email protected] Remove unused autosubmit configuration file (flutter/packages#4410) 2023-07-07 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.5.0 to 1.6.0 in /packages/file_selector/file_selector_android/android (flutter/packages#4312) 2023-07-07 [email protected] Roll Flutter from bc49cd1 to d55a7d8 (17 revisions) (flutter/packages#4403) 2023-07-07 [email protected] [shared_preferences] Variable binding in a condition requires an initializer fix (flutter/packages#4407) 2023-07-07 [email protected] [go_router] implemented helpers for StatefulShellRoute (flutter/packages#4228) 2023-07-07 [email protected] [in_app_purchase_android] Bump com.android.billingclient:billing from 5.2.0 to 6.0.0. (flutter/packages#4390) 2023-07-07 [email protected] [tool] Use 'flutter pub get' for Flutter packages (flutter/packages#4397) 2023-07-07 [email protected] [ci] Enable LUCI stable custom Linux tests (flutter/packages#4404) 2023-07-07 [email protected] [tool] Fix --current-package for app-facing packages (flutter/packages#4399) 2023-07-07 [email protected] [ci] Switch some tests to LUCI (flutter/packages#4395) 2023-07-07 [email protected] [flutter_markdown] Pass parent TextStyle down to MarkdownElementBuilder.visitElementAfter (flutter/packages#4393) 2023-07-07 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.3.3 to 2.20.3 (flutter/packages#4394) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the tool only needs to support back to Flutter 3.3 (the oldest version we still run CI with), this updates the tool to the corresponding minimum Dart version.
This allows the use of
super
parameters, sodart fix --apply
was run to convert them all (and remove all the includes that were only needed for setting default values).Also opportunistically cleans up a bunch of unnecessary, very old
dart:async
includes. (Other than those removals, the changes here are alldart fix
-generated.)