Skip to content

[webview_flutter_platform_interface] Adds url to WebResourceError #4439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 13, 2023
Merged

[webview_flutter_platform_interface] Adds url to WebResourceError #4439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc69344
interface implementation
bparrishMines Jul 11, 2023
66e906c
fix name in pubspec
bparrishMines Jul 11, 2023
e6be17d
Merge branch 'main' of github.com:flutter/packages into wk_fulldesc_intf
bparrishMines Jul 12, 2023
7e55df1
Merge branch 'main' into wk_fulldesc_intf
stuartmorgan-g Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/webview_flutter/webview_flutter_platform_interface/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.4.0

* Adds support to retrieve the url from a web resource loading error. See `WebResourceError.url`.

## 2.3.1

* Removes obsolete null checks on non-nullable values.
Expand Down
4 changes: 4 additions & 0 deletions .../webview_flutter/webview_flutter_platform_interface/lib/src/types/web_resource_error.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ class WebResourceError {
required this.description,
this.errorType,
this.isForMainFrame,
this.url,
});

/// Raw code of the error from the respective platform.
Expand All @@ -120,4 +121,7 @@ class WebResourceError {

/// Whether the error originated from the main frame.
final bool? isForMainFrame;

/// The URL for which the failing resource request was made.
final String? url;
}
2 changes: 1 addition & 1 deletion packages/webview_flutter/webview_flutter_platform_interface/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ repository: https://github.com/flutter/packages/tree/main/packages/webview_flutt
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview_flutter%22
# NOTE: We strongly prefer non-breaking changes, even at the expense of a
# less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes
version: 2.3.1
version: 2.4.0

environment:
sdk: ">=2.18.0 <4.0.0"
Expand Down