-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Remove equatable
and xml
allowances
#4489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only package that was using the `equtable` package removed it, so we no longer need this allowance. Part of flutter/flutter#122713
equatable
and xml
allowances
bparrishMines
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 18, 2023
flutter/packages@6889cca...3e8b813 2023-07-18 [email protected] [video_player] Fix iOS crash with multiple players (flutter/packages#4202) 2023-07-17 [email protected] [pigeon] Enable Android emulator tests in CI (flutter/packages#4484) 2023-07-17 [email protected] [video_player] Add optional web options [Platform interface] (flutter/packages#4433) 2023-07-17 [email protected] [google_maps_flutter_platform_interface] Platform interface changes for #3258 (flutter/packages#4478) 2023-07-17 [email protected] [video_player] fix: add missing isPlaybackLikelyToKeepUp check. (flutter/packages#3826) 2023-07-17 [email protected] [camerax] Add flash configuration for image capture (flutter/packages#3800) 2023-07-17 [email protected] Remove `equatable` and `xml` allowances (flutter/packages#4489) 2023-07-17 [email protected] [ci] Switch Linux platform tests to LUCI (flutter/packages#4479) 2023-07-17 [email protected] [ci] Adjust bot configurations (flutter/packages#4485) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
flutter/packages@6889cca...3e8b813 2023-07-18 [email protected] [video_player] Fix iOS crash with multiple players (flutter/packages#4202) 2023-07-17 [email protected] [pigeon] Enable Android emulator tests in CI (flutter/packages#4484) 2023-07-17 [email protected] [video_player] Add optional web options [Platform interface] (flutter/packages#4433) 2023-07-17 [email protected] [google_maps_flutter_platform_interface] Platform interface changes for flutter#3258 (flutter/packages#4478) 2023-07-17 [email protected] [video_player] fix: add missing isPlaybackLikelyToKeepUp check. (flutter/packages#3826) 2023-07-17 [email protected] [camerax] Add flash configuration for image capture (flutter/packages#3800) 2023-07-17 [email protected] Remove `equatable` and `xml` allowances (flutter/packages#4489) 2023-07-17 [email protected] [ci] Switch Linux platform tests to LUCI (flutter/packages#4479) 2023-07-17 [email protected] [ci] Adjust bot configurations (flutter/packages#4485) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only package that was using the
equatable
package removed it, so we no longer need this allowance.The only package depending on
xml
wasflutter_migrate
, but it never actually used it, so that can be removed as well.Part of flutter/flutter#122713