Skip to content

[ci] Convert version presubmit check to LUCI #4822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .ci/Dockerfile

This file was deleted.

7 changes: 3 additions & 4 deletions .ci/scripts/check_version.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,13 @@
# found in the LICENSE file.
set -e

# For pre-submit, this is currently run in Cirrus; see TODO below.
# For pre-submit, check for missing or breaking changes that don't have a
# corresponding override label.
# For post-submit, ignore platform interface breaking version changes and
# missing version/CHANGELOG detection since PR-level overrides aren't available
# in post-submit.
if [[ $LUCI_PR == "" ]]; then
./script/tool_runner.sh version-check --ignore-platform-interface-breaks
else
# TODO(stuartmorgan): Migrate this check from Cirrus. See
# https://github.com/flutter/flutter/issues/130076
:
./script/tool_runner.sh version-check --check-for-missing-changes --pr-labels="$PR_OVERRIDE_LABELS"
fi
9 changes: 5 additions & 4 deletions .ci/targets/repo_checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,14 @@ tasks:
script: script/tool_runner.sh
args: ["dependabot-check"]
always: true
- name: publishability
script: script/tool_runner.sh
args: ["publish-check", "--allow-pre-release"]
always: true
- name: CHANGELOG and version validation
script: .ci/scripts/check_version.sh
always: true
- name: federated safety check
script: .ci/scripts/check_federated_safety.sh
always: true
# This is the slowest test, so prefer keeping it last.
- name: publishability
script: script/tool_runner.sh
args: ["publish-check", "--allow-pre-release"]
always: true
34 changes: 0 additions & 34 deletions .cirrus.yml

This file was deleted.