Skip to content

[process] Import the process package #5095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 9, 2023
Merged

[process] Import the process package #5095

merged 11 commits into from
Oct 9, 2023

Conversation

stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Oct 9, 2023 •
edited
Loading

Imports the process platform from https://github.com/google/process.dart

  • As there is not much history in the package, this imports it as a copy instead of going through the process of actually merging the commit history of that repo into this one.
  • The only changes relative to the current source in that repo are adjustments for repo conventions (such as updating pubspec.yaml, and running dart fix --apply after removing the custom analysis options in order to bring it into alignment with repo analysis options).

Fixes flutter/flutter#130915

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

gspencergoog
gspencergoog approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2023
@auto-submit auto-submit bot merged commit 9804d95 into flutter:main Oct 9, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 10, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll
9804d95 [process] Import the process package (flutter/packages#5095)
afc6a2c
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll
Roll Packages from 7de08ec to 4b483f2 (8 revisions) (#136258)
665c876 
flutter/packages@7de08ec...4b483f2

2023-10-10 [email protected] Run tests on either macOS 12 or macOS 13 (flutter/packages#5089)
2023-10-10 [email protected] [google_map_flutter_ios] fix `didBeginDraggingMarker` typo (flutter/packages#5085)
2023-10-09 [email protected] [process] Import the `process` package (flutter/packages#5095)
2023-10-09 [email protected] [go_router] Fixes missing state.extra in onException() (flutter/packages#5077)
2023-10-09 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.0 to 2.22.1 (flutter/packages#5094)
2023-10-09 [email protected] Roll Flutter from 5207a30 to f52fe4f (18 revisions) (flutter/packages#5093)
2023-10-09 [email protected] [platform] Example app for platform (flutter/packages#4834)
2023-10-09 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.2.0 to 2.3.0 (flutter/packages#5091)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll @Mairramer
Roll Packages from 7de08ec to 4b483f2 (8 revisions) (flutter#136258)
410e9d7 
flutter/packages@7de08ec...4b483f2

2023-10-10 [email protected] Run tests on either macOS 12 or macOS 13 (flutter/packages#5089)
2023-10-10 [email protected] [google_map_flutter_ios] fix `didBeginDraggingMarker` typo (flutter/packages#5085)
2023-10-09 [email protected] [process] Import the `process` package (flutter/packages#5095)
2023-10-09 [email protected] [go_router] Fixes missing state.extra in onException() (flutter/packages#5077)
2023-10-09 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.0 to 2.22.1 (flutter/packages#5094)
2023-10-09 [email protected] Roll Flutter from 5207a30 to f52fe4f (18 revisions) (flutter/packages#5093)
2023-10-09 [email protected] [platform] Example app for platform (flutter/packages#4834)
2023-10-09 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.2.0 to 2.3.0 (flutter/packages#5091)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@devoncarew devoncarew mentioned this pull request May 20, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider adopting process and platform into the flutter/packages repository
2 participants
@stuartmorgan-g @gspencergoog