[plugin_platform_interface] Switch mixin to mixin class
#5420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test mixin is currently declared as a `class`, which causes problems for projects with a minimum Dart version of 3.0. This switches it to `mixin class`; ideally it would just be a `mixin`, but in theory that could break something, so since this is such a core package in the ecosystem we want to be as conservative as possible. (While the breaking change would only in theory happen to test code, it's possible that someone ignored the `visibleForTesting`, and we have an easy way to avoid the possibility entirely.) Fixes flutter/flutter#123241
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This is necessary in order to roll the repo minimums forward as usual for the stable release. |
|
test-exempt: the SDK minimum change is a test, since it would otherwise break compilation |
tarrinneal
approved these changes
Nov 17, 2023
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 20, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 20, 2023
flutter/packages@07b4b29...c5443ad 2023-11-20 [email protected] [webview_flutter] Support for handling basic authentication requests (Platform Interface) (flutter/packages#5362) 2023-11-18 [email protected] Roll Flutter from 53a57ad to 6cf9ab0 (31 revisions) (flutter/packages#5426) 2023-11-18 [email protected] [shared_preferences_web] migrate to pkg:web (flutter/packages#5414) 2023-11-18 [email protected] [ci] Roll minimum allowable Flutter to 3.10 (flutter/packages#5425) 2023-11-18 [email protected] [path_provider_android] Run tests on AVDs running Android 34 (flutter/packages#5222) 2023-11-17 [email protected] [pigeon] isEnum, isClass, fix swift casting, default values, optional method arguments, named method arguments (flutter/packages#5355) 2023-11-17 [email protected] [plugin_platform_interface] Switch mixin to `mixin class` (flutter/packages#5420) 2023-11-17 [email protected] [go_router] Fixes use of `Iterable` (flutter/packages#5421) 2023-11-17 [email protected] [pigeon] Adds `analyzer` 6.x compatibility (flutter/packages#5418) 2023-11-17 [email protected] Update release step to 3.16 (flutter/packages#5416) 2023-11-17 [email protected] [file_selector_web] migrate to pkg:web (flutter/packages#5413) 2023-11-16 [email protected] [video_player] Improve macOS frame management (flutter/packages#5078) 2023-11-16 [email protected] Roll Flutter from e8c2bb1 to 53a57ad (39 revisions) (flutter/packages#5412) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
The test mixin is currently declared as a `class`, which causes problems for projects with a minimum Dart version of 3.0. This switches it to `mixin class`; ideally it would just be a `mixin`, but in theory that could break something, so since this is such a core package in the ecosystem we want to be as conservative as possible. (While the breaking change would only in theory happen to test code, it's possible that someone ignored the `visibleForTesting`, and we have an easy way to avoid the possibility entirely.) Fixes flutter/flutter#123241
Closed
12 tasks
16 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
The test mixin is currently declared as a `class`, which causes problems for projects with a minimum Dart version of 3.0. This switches it to `mixin class`; ideally it would just be a `mixin`, but in theory that could break something, so since this is such a core package in the ecosystem we want to be as conservative as possible. (While the breaking change would only in theory happen to test code, it's possible that someone ignored the `visibleForTesting`, and we have an easy way to avoid the possibility entirely.) Fixes flutter/flutter#123241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test mixin is currently declared as a
class, which causes problems for projects with a minimum Dart version of 3.0. This switches it tomixin class; ideally it would just be amixin, but in theory that could break something, so since this is such a core package in the ecosystem we want to be as conservative as possible. (While the breaking change would only in theory happen to test code, it's possible that someone ignored thevisibleForTesting, and we have an easy way to avoid the possibility entirely.)Fixes flutter/flutter#123241
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).