Skip to content

[camerax] Wrap Android classes/methods required for implementing setting focus & exposure points and offset #5659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jan 24, 2024

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Dec 12, 2023

Wraps CameraX APIs needed to at least implement setting focus and exposure points and offset (setFocusPoint,setExposurePoint, setExposureOffset). Listed by class:

CameraControl

FocusMeteringAction

FocusMeteringResult

MeteringPoint

Part of flutter/flutter#120468 and flutter/flutter#120467.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@camsim99 camsim99 changed the title [camerax] Wrap Android classes/methods required for implementing focus & exposure controls [camerax] Wrap Android classes/methods required for implementing setting focus & exposure points and offset Jan 3, 2024
@camsim99 camsim99 marked this pull request as ready for review January 9, 2024 01:15
@camsim99 camsim99 requested a review from gmackall January 9, 2024 01:15
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just 3 typo fix suggestions

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2024
Copy link
Contributor

auto-submit bot commented Jan 24, 2024

auto label is removed for flutter/packages/5659, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2024
@auto-submit auto-submit bot merged commit dced730 into flutter:main Jan 24, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 25, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 25, 2024
flutter/packages@8fbdf65...21b5abb

2024-01-24 [email protected] Add rfw widgets (flutter/packages#5661)
2024-01-24 [email protected] [camera] add heif support image iOS (flutter/packages#4586)
2024-01-24 [email protected] [webview_flutter_android] Add javascript panel interface for android (flutter/packages#5796)
2024-01-24 [email protected] [camerax] Wrap Android classes/methods required for implementing setting focus & exposure points and offset (flutter/packages#5659)
2024-01-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.2.0 to 4.3.0 (flutter/packages#5967)
2024-01-24 [email protected] Roll Flutter from 5b673c2 to 19b06f4 (21 revisions) (flutter/packages#5968)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants