-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[camerax] Wrap Android classes/methods required for implementing setting focus & exposure points and offset #5659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmackall
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just 3 typo fix suggestions
packages/camera/camera_android_camerax/pigeons/camerax_library.dart
Outdated
Show resolved
Hide resolved
...mera_android_camerax/android/src/test/java/io/flutter/plugins/camerax/CameraControlTest.java
Outdated
Show resolved
Hide resolved
packages/camera/camera_android_camerax/lib/src/camera_control.dart
Outdated
Show resolved
Hide resolved
….dart Co-authored-by: Gray Mackall <[email protected]>
…o/flutter/plugins/camerax/CameraControlTest.java Co-authored-by: Gray Mackall <[email protected]>
…dart Co-authored-by: Gray Mackall <[email protected]>
auto label is removed for flutter/packages/5659, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 25, 2024
…ing setting focus & exposure points and offset (flutter/packages#5659)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 25, 2024
flutter/packages@8fbdf65...21b5abb 2024-01-24 [email protected] Add rfw widgets (flutter/packages#5661) 2024-01-24 [email protected] [camera] add heif support image iOS (flutter/packages#4586) 2024-01-24 [email protected] [webview_flutter_android] Add javascript panel interface for android (flutter/packages#5796) 2024-01-24 [email protected] [camerax] Wrap Android classes/methods required for implementing setting focus & exposure points and offset (flutter/packages#5659) 2024-01-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.2.0 to 4.3.0 (flutter/packages#5967) 2024-01-24 [email protected] Roll Flutter from 5b673c2 to 19b06f4 (21 revisions) (flutter/packages#5968) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps CameraX APIs needed to at least implement setting focus and exposure points and offset (
setFocusPoint
,setExposurePoint
,setExposureOffset
). Listed by class:CameraControl
startFocusAndMetering
cancelFocusAndMetering
setExposureCompensationIndex
FocusMeteringAction
create
method for this classFocusMeteringResult
create
method for this classisFocusSuccessful
MeteringPoint
create
method for the points thatSurfaceOrientedMeteringPointFactory
createsgetDefaultPointSize
Part of flutter/flutter#120468 and flutter/flutter#120467.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).