[pointer_interceptor_web] Update package APIs and tests. #5785

ditman · 2024-01-02T23:03:08Z

Changes:

Updates the web implementation of the pointer_interceptor to package:web, and the latest HtmlElementView APIs available on Flutter.
Resolves a timing issue in integration tests by waiting a few frames before doing any assertions from the DOM of a Flutter Web app, that should fix flutter rolls.

Issues:

Fixes [pointer_interceptor_web] Breaking the packages roll. flutter#140834
Fixes [pointer_interceptor] migrate to pkg:web flutter#139753
Closes [pointer_interceptor_web] migrates pointer interceptor to package:web #5673 (Credit to @balvinderz!)

Tests

Tested manually. All integration tests pass locally.

Co-authored-by: balvinderz <b📧2@g📬l.com>

Pre-launch Checklist

ditman · 2024-01-02T23:09:54Z

/cc @mdebbar migrated the package to the new HtmlElementView.fromTagName API, it simplifies the code a lot (as if the API was added for code like this 😜)!

tarrinneal

Approved, might be worth waiting for @stuartmorgan to take a look though.

packages/pointer_interceptor/pointer_interceptor_web/example/integration_test/widget_test.dart

mdebbar

Looks good, thanks for the cleanup!

The only thing I would recommend is making onElementCreated a method so we don't keep creating a new closure on every build.

stuartmorgan-g

LGTM

packages/pointer_interceptor/pointer_interceptor_web/example/integration_test/widget_test.dart

packages/pointer_interceptor/pointer_interceptor_web/example/lib/main.dart

packages/pointer_interceptor/pointer_interceptor_web/lib/pointer_interceptor_web.dart

ditman · 2024-01-03T19:23:07Z

Rolling the 🎲 with autosubmit!

auto-submit · 2024-01-03T19:24:42Z

auto label is removed for flutter/packages/5785, due to - The status or check suite Linux_android android_platform_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

stuartmorgan-g · 2024-01-03T19:26:32Z

🎲

stuartmorgan-g · 2024-01-03T19:27:30Z

Rolling the 🎲 with autosubmit!

🎲

Maybe the problem is that the die keeps coming up "1" 🙂

auto-submit · 2024-01-03T19:37:18Z

auto label is removed for flutter/packages/5785, due to - The status or check suite Linux_android android_platform_tests_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

ditman · 2024-01-03T19:53:12Z

Maybe the problem is that the die keeps coming up "1" 🙂

Those dies are not to spec! RFC 1149.5 specifies 4 as the standard IEEE-vetted random number.

tarrinneal · 2024-01-03T19:59:47Z

My turn 🎲 🎲 🎲 🎲 🎲 🎲 (6)

auto-submit · 2024-01-03T20:14:01Z

auto label is removed for flutter/packages/5785, due to - The status or check suite Linux_android android_platform_tests_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

Also: migrate test app to package:web.

ditman · 2024-01-03T21:28:11Z

Removed bump to the master version, it seems other shards were breaking because of it.

🎲

auto-submit · 2024-01-03T22:28:58Z

auto label is removed for flutter/packages/5785, due to - The status or check suite Linux_android android_platform_tests_api_33_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

…tter/packages#5785)

flutter/packages@bbb4134...31fc7b5 2024-01-04 [email protected] bump mockito across repo to 5.4.4 (flutter/packages#5794) 2024-01-03 [email protected] [various] Sync lints with flutter/flutter (flutter/packages#5717) 2024-01-03 [email protected] [pointer_interceptor_web] Update package APIs and tests. (flutter/packages#5785) 2024-01-03 [email protected] [google_sign_in] Correct method channel `clearAuthCache` declaration (flutter/packages#5787) 2024-01-03 [email protected] [google_sign_in] Correct clearAuthCache declarations (flutter/packages#5693) 2024-01-03 [email protected] Unpin mac_toolchain version (flutter/packages#5683) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@balvinderz

## Changes: * Updates the web implementation of the `pointer_interceptor` to `package:web`, and the latest `HtmlElementView` APIs available on Flutter. * Resolves a timing issue in integration tests by waiting a few frames before doing any assertions from the DOM of a Flutter Web app, that should fix flutter rolls. ## Issues: * Fixes flutter/flutter#140834 * Fixes flutter/flutter#139753 * Closes flutter#5673 (Credit to @balvinderz!) ## Tests * Tested manually. All integration tests pass locally. --- Co-authored-by: balvinderz <[email protected]>

ditman requested a review from stuartmorgan-g January 2, 2024 23:03

github-actions bot added p: pointer_interceptor platform-web labels Jan 2, 2024

ditman mentioned this pull request Jan 2, 2024

[pointer_interceptor_web] migrates pointer interceptor to package:web #5673

Closed

11 tasks

tarrinneal approved these changes Jan 3, 2024

View reviewed changes

packages/pointer_interceptor/pointer_interceptor_web/example/integration_test/widget_test.dart Outdated Show resolved Hide resolved

mdebbar approved these changes Jan 3, 2024

View reviewed changes

stuartmorgan-g approved these changes Jan 3, 2024

View reviewed changes

ditman force-pushed the fix-pointer-interceptor-web-tests branch from 7b31df1 to 9ab2360 Compare January 3, 2024 19:06

ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024

tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024

ditman added 7 commits January 3, 2024 13:25

Update web app

ac05236

Update integration test

a4f2ef8

Update to latest HtmlElementView API.

097ddcc

Restore license that was removed by mistake.

b835b02

Makes example app Widget directly testable.

6fe548c

Also: migrate test app to package:web.

Fix subtle test bug with position rounding.

3a8475d

dart format .

0a957c4

Clean imports, make onElementCreated a tear-off

df9e305

ditman force-pushed the fix-pointer-interceptor-web-tests branch from 9ab2360 to df9e305 Compare January 3, 2024 21:26

ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024

ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024

auto-submit bot merged commit 6b2249f into flutter:main Jan 3, 2024

ditman deleted the fix-pointer-interceptor-web-tests branch January 3, 2024 22:48

engine-flutter-autoroll mentioned this pull request Jan 4, 2024

Roll Packages from bbb41347518e to 31fc7b5dd000 (6 revisions) flutter/flutter#140967

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 4, 2024

6b2249f [pointer_interceptor_web] Update package APIs and tests. (flu…

0856f04

…tter/packages#5785)

reidbaker mentioned this pull request Jan 12, 2024

Dialog Debug #5881

Closed

reidbaker mentioned this pull request Jan 19, 2024

[in_app_purchase] Add play country code api #5941

Merged

12 tasks

ditman mentioned this pull request Jan 25, 2024

[cocoon] Google Sign In button not showing up. flutter/flutter#142195

Closed

reidbaker mentioned this pull request Feb 19, 2024

[in_app_purchase_android] Add UserChoiceBilling mode. #6162

Merged

16 tasks

[pointer_interceptor_web] Update package APIs and tests. #5785

[pointer_interceptor_web] Update package APIs and tests. #5785

Uh oh!

Conversation

ditman commented Jan 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes:

Issues:

Tests

Pre-launch Checklist

Uh oh!

ditman commented Jan 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tarrinneal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mdebbar left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ditman commented Jan 3, 2024

Uh oh!

auto-submit bot commented Jan 3, 2024

Uh oh!

stuartmorgan-g commented Jan 3, 2024

Uh oh!

stuartmorgan-g commented Jan 3, 2024

Uh oh!

auto-submit bot commented Jan 3, 2024

Uh oh!

ditman commented Jan 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tarrinneal commented Jan 3, 2024

Uh oh!

auto-submit bot commented Jan 3, 2024

Uh oh!

ditman commented Jan 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

auto-submit bot commented Jan 3, 2024

Uh oh!

Uh oh!

ditman commented Jan 2, 2024 •

edited

Loading

ditman commented Jan 2, 2024 •

edited

Loading

ditman commented Jan 3, 2024 •

edited

Loading

ditman commented Jan 3, 2024 •

edited

Loading