Skip to content

[pointer_interceptor] fix width and height unset warning on web platform #5864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 18, 2024
Merged

[pointer_interceptor] fix width and height unset warning on web platform #5864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fe9d02a
fix #141323 width and height unset
cedvdb Jan 10, 2024
6ab3e6e
change version
cedvdb Jan 10, 2024
d62990b
add changelog entry for 10.0.2
cedvdb Jan 10, 2024
39c3881
Update pubspec.yaml
cedvdb Jan 10, 2024
75d2147
Update pubspec.yaml
cedvdb Jan 10, 2024
c83a978
Update pubspec.yaml
cedvdb Jan 10, 2024
697dd1d
Update pubspec.yaml
cedvdb Jan 10, 2024
bf225ab
Update pubspec.yaml
cedvdb Jan 11, 2024
7c75573
fix comment
cedvdb Jan 11, 2024
963ade7
Merge branch 'fix-141323-pointer-interceptor-width-height-unset' of g…
cedvdb Jan 11, 2024
4c24b32
Merge branch 'main' into fix-141323-pointer-interceptor-width-height-…
cedvdb Jan 12, 2024
58a68b6
Tweaks to metadata.
ditman Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pointer_interceptor/pointer_interceptor_web/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.10.1+2

* Fixes "width and height missing" warning on web.

## 0.10.1+1

* Updates minimum required plugin_platform_interface version to 2.1.7.
Expand Down
5 changes: 4 additions & 1 deletion packages/pointer_interceptor/pointer_interceptor_web/lib/pointer_interceptor_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ class PointerInterceptorWeb extends PointerInterceptorPlatform {

// Slightly modify the created `element` (for `debug` mode).
void _onElementCreated(Object element) {
(element as web.HTMLElement).style.backgroundColor = 'rgba(255, 0, 0, .5)';
(element as web.HTMLElement)
..style.width = '100%'
..style.height = '100%'
..style.backgroundColor = 'rgba(255, 0, 0, .5)';
}

@override
Expand Down
2 changes: 1 addition & 1 deletion packages/pointer_interceptor/pointer_interceptor_web/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: pointer_interceptor_web
description: Web implementation of the pointer_interceptor plugin.
repository: https://github.com/flutter/packages/tree/main/packages/pointer_interceptor/pointer_interceptor_web
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3Apointer_interceptor
version: 0.10.1+1
version: 0.10.1+2

environment:
sdk: ^3.2.0
Expand Down