Skip to content

[ci] Fix deprecated package:web usages. #5875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Jan 11, 2024

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman changed the title [draft if needed] Replace deprecated web package usages [ci] Fix deprecated package:web usages. Jan 12, 2024
@ditman
Copy link
Member

ditman commented Jan 12, 2024

I'm suspicious with the minimum flutter version for this (for the flutter versions that pin 0.3.0), we might need to change this to a range that skips 0.4.1

@ditman ditman requested a review from stuartmorgan-g January 12, 2024 00:42
@ditman
Copy link
Member

ditman commented Jan 12, 2024

Because web_benchmarks depends on flutter_test from sdk which depends on web 0.3.0, web 0.3.0 is required.
So, because web_benchmarks depends on web ^0.4.1, version solving failed.


You can try the following suggestion to make the pubspec resolve:
* Consider downgrading your constraint on web: flutter pub add web:^0.3.0

Yuck

This reverts commit 368dc76.
Some packages use an import that was deprecated in package:web 0.4.1.
This is considered an analysis failure.

This PR pins the version of package:web on those packages to the latest
compatible version of the package.
@ditman
Copy link
Member

ditman commented Jan 12, 2024

Solved by: dart-lang/web#140 (published v 0.4.2 that doesn't deprecate the legacy import helpers.dart)

@ditman ditman mentioned this pull request Jan 12, 2024
11 tasks
@ditman
Copy link
Member

ditman commented Jan 13, 2024

(Closing)

@ditman ditman closed this Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants