[ci] Add flags to formatter command to decide which formatters to run #5905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
Jan 16, 2024
jmagman
commented
Jan 17, 2024
| final String? swiftFormat = getNullableStringArg(_swiftFormatArg); | ||
| if (swiftFormat != null) { | ||
| await _formatSwift(swiftFormat, files); | ||
| if (getBoolArg(_dartArg)) { |
There was a problem hiding this comment.
Forgot to add tests for these flags.
jmagman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 19, 2024
flutter/packages@83c2c4d...129e08c 2024-01-19 [email protected] [pigeon] Run swift-format on ungenerated example app Swift files (flutter/packages#5934) 2024-01-19 [email protected] [path_provider_foundation] Run swift-format on Swift files (flutter/packages#5935) 2024-01-19 [email protected] [shared_preferences_foundation] Run swift-format on Swift files (flutter/packages#5933) 2024-01-19 [email protected] [various] Run swift-format on example app Swift files (flutter/packages#5931) 2024-01-19 [email protected] [camera_avfoundation] Remove development team from Xcode example app (flutter/packages#5930) 2024-01-18 [email protected] [webview_flutter_wkwebview] Add javascript panel interface for wkwebview (flutter/packages#5795) 2024-01-18 [email protected] [two_dimensional_scrollables] Fix must_call_super (flutter/packages#5921) 2024-01-18 [email protected] [pointer_interceptor] fix width and height unset warning on web platform (flutter/packages#5864) 2024-01-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.0 to 3.23.1 (flutter/packages#5922) 2024-01-18 [email protected] [google_maps_flutter] Clean up iOS example project (flutter/packages#5925) 2024-01-18 [email protected] [ci] Add flags to formatter command to decide which formatters to run (flutter/packages#5905) 2024-01-18 [email protected] Update tests to Xcode 15 and iOS 17 simulator (flutter/packages#5914) 2024-01-18 [email protected] Roll Flutter from def6af0 to f77f824 (25 revisions) (flutter/packages#5924) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
12 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get ready for a world where
swift-formatis available on thePATHhttps://flutter-review.googlesource.com/c/recipes/+/54020format --clang-format --java --kotlin --swift --dartflags to decide whether to run specific formatters, as opposed to using thepath. Keepswift-formatoptional but default the others to run. This matches the current behavior on Linux.*-pathvariants of each.This will allow us to run
format --swift --no-clang-format --no-java --no-kotlin --no-darton the macOS bot so it doesn't duplicate sameformatcall run on Linux.Part of flutter/flutter#41129
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.