[go_router]: fix GoRouter.optionURLReflectsImperativeAPIs flag works with new imperative APIs #6236

anisovdev · 2024-03-01T16:16:03Z

After 13.0.0 release of go_router package GoRouter.optionURLReflectsImperativeAPIs is not working correct.
Isn't correct = url in browser doesn't updates after push, example you can see in new test, or in linked issue

List which issues are fixed by this PR. You must list at least one issue.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

google-cla · 2024-03-01T16:16:08Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

anisovdev · 2024-03-06T07:01:43Z

@chunhtai
can you review this pull request?

anisovdev · 2024-03-11T08:53:03Z

@Hangyujin
Seems like @chunhtai is not online for the last 2 mouth. Can you review this Pull Request?

anisovdev · 2024-03-15T14:32:20Z

@polina-c mb you can help with review this PR?
This is critical issue to me and i want to see this changes on pub.dev as soon as possible

polina-c · 2024-03-15T16:18:04Z

@polina-c mb you can help with review this PR? This is critical issue to me and i want to see this changes on pub.dev as soon as possible

@Hangyujin seems to be better person to review this

hannah-hyj · 2024-03-15T19:15:34Z

Hi, this PR looks good to me, thank you for fixing this issue introduced by 13.0.0.

@johnpryan Hi John, can you take a second look at this pr since chun-heng is on vacation? This pr fixes an issue that is introduced by go_router 13.0.0 because 13.0.0 refactored RouteMatchList to be a tree structure.

hannah-hyj · 2024-03-15T19:15:41Z

@anisovdev Can you bump the version to 13.2.2 and also update pubspec.yaml?

hannah-hyj

LGTM

hannah-hyj · 2024-03-15T19:04:23Z

packages/go_router/CHANGELOG.md

@@ -2,6 +2,7 @@

 - Updates minimum supported SDK version to Flutter 3.16/Dart 3.2.
 - Fixes memory leaks.
+- GoRouter.optionURLReflectsImperativeAPIs now works correctly with new imperative APIs


Nit: This description sounds like you changed the "optionURLReflectsImperativeAPIs" flag. You can update the description like "Fixes restoreRouteInformation issue when GoRouter.optionURLReflectsImperativeAPIs is true and the last match is ShellRouteMatch"

cleanup CHANGELOG.md

anisovdev · 2024-03-16T05:18:36Z

@Hangyujin
bumped

auto-submit · 2024-03-20T23:17:21Z

auto label is removed for flutter/packages/6236, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

hannah-hyj · 2024-03-20T23:19:01Z

@johnpryan Hi John, can you take a second look at this pr since chun-heng is on vacation? This pr fixes an issue that is introduced by go_router 13.0.0 because 13.0.0 refactored RouteMatchList to be a tree structure.

anisovdev · 2024-03-27T10:34:18Z

@johnpryan Review please this Pull Request

anisovdev · 2024-03-28T09:32:28Z

@Hangyujin now this PR has two review

…g works with new imperative APIs (flutter/packages#6236)

flutter/packages@924c7e6...51faaa1 2024-03-29 [email protected] [shared_preferences] Update mockito to the new version available 5.2.0 (flutter/packages#6332) 2024-03-29 [email protected] Manual roll Flutter (stable) from 68bfaea to 300451a (2 revisions) (flutter/packages#6433) 2024-03-28 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.exifinterface:exifinterface from 1.3.6 to 1.3.7 in /packages/image_picker/image_picker_android/android (flutter/packages#5705) 2024-03-28 [email protected] Manual roll Flutter from dbdcead to 89ea492 (54 revisions) (flutter/packages#6431) 2024-03-28 [email protected] [ci] Adds sleep 60s to release action. (flutter/packages#6405) 2024-03-28 [email protected] [go_router]: fix GoRouter.optionURLReflectsImperativeAPIs flag works with new imperative APIs (flutter/packages#6236) 2024-03-28 [email protected] [interactive_media_ads] Reland "Creates and adds the interactive_media_ads plugin #6060" (flutter/packages#6425) 2024-03-28 [email protected] [google_sign_in_ios] Pins GoogleSignIn to 7.0.0 in podspec. (flutter/packages#6430) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…with new imperative APIs (flutter#6236) After 13.0.0 release of go_router package `GoRouter.optionURLReflectsImperativeAPIs` is not working correct. Isn't correct = url in browser doesn't updates after push, example you can see in new test, or in linked issue [List which issues are fixed by this PR. You must list at least one issue.](flutter/flutter#142053)

strelas and others added 11 commits February 28, 2024 17:04

fix optionURLReflectsImperativeAPIs flag

31eb6cd

fix optionURLReflectsImperativeAPIs flag x2

182164e

fix optionURLReflectsImperativeAPIs flag x3

4bcaf1f

fix

3d643d9

fix

f08a445

mb now

7d2e95f

correct format

cf3b47f

add test

2b9991a

Merge branch 'flutter:main' into main

b80628e

update CHANGELOG.md

69e8ff6

Merge remote-tracking branch 'origin/main'

e5c4454

anisovdev requested a review from chunhtai as a code owner March 1, 2024 16:16

anisovdev changed the title ~~go_router: fix GoRouter.optionURLReflectsImperativeAPIs flag works with new imperative APIs~~ [go_router]: fix GoRouter.optionURLReflectsImperativeAPIs flag works with new imperative APIs Mar 1, 2024

github-actions bot added the p: go_router label Mar 1, 2024

strelas and others added 6 commits March 1, 2024 21:17

revert some unused changed

57c4cf9

increase version

d872c70

correct package version in CHANGELOG.md

a906a9b

Merge branch 'main' into main

a8a5ac3

Merge branch 'main' into main

867d01b

Merge branch 'main' into main

e38431c

Merge branch 'main' into main

19e0e2d

hannah-hyj self-requested a review March 13, 2024 00:45

anisovdev added 2 commits March 13, 2024 19:33

Merge branch 'main' into main

27ec78a

Merge branch 'main' into main

bddb3b0

anisovdev mentioned this pull request Mar 15, 2024

Starting from 13.0.0 browser address bar doesn't reflect a route pushed into a StatefulShellRoute branch while optionURLReflectsImperativeAPIs is set to true flutter/flutter#142053

Closed

hannah-hyj approved these changes Mar 15, 2024

View reviewed changes

strelas and others added 2 commits March 16, 2024 10:17

update package version

dc2a4e8

cleanup CHANGELOG.md

Merge branch 'main' into main

6389cee

Merge branch 'main' into main

9fd4736

hannah-hyj requested a review from johnpryan March 19, 2024 05:21

hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 20, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 20, 2024

anisovdev added 2 commits March 22, 2024 10:44

Merge branch 'main' into main

42fc4b3

Merge branch 'main' into main

ea4cc0c

johnpryan approved these changes Mar 27, 2024

View reviewed changes

Merge branch 'main' into main

6c24c2e

hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2024

auto-submit bot merged commit c7d30e2 into flutter:main Mar 28, 2024

engine-flutter-autoroll mentioned this pull request Mar 29, 2024

Roll Packages from 924c7e6e899d to ad0274ad12dd (7 revisions) flutter/flutter#145977

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2024

c7d30e2 [go_router]: fix GoRouter.optionURLReflectsImperativeAPIs fla…

2df63bb

…g works with new imperative APIs (flutter/packages#6236)

engine-flutter-autoroll mentioned this pull request Mar 29, 2024

Roll Packages from 924c7e6e899d to 51faaa156b61 (8 revisions) flutter/flutter#145986

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2024

c7d30e2 [go_router]: fix GoRouter.optionURLReflectsImperativeAPIs fla…

9c35ea7

…g works with new imperative APIs (flutter/packages#6236)

reidbaker mentioned this pull request Apr 1, 2024

[camera_android_camerax] Move integration_test dependency to tests reidbaker/packages#4

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[go_router]: fix GoRouter.optionURLReflectsImperativeAPIs flag works with new imperative APIs #6236

[go_router]: fix GoRouter.optionURLReflectsImperativeAPIs flag works with new imperative APIs #6236

Uh oh!

anisovdev commented Mar 1, 2024 •

edited

Loading

Uh oh!

google-cla bot commented Mar 1, 2024

Uh oh!

anisovdev commented Mar 6, 2024

Uh oh!

anisovdev commented Mar 11, 2024

Uh oh!

anisovdev commented Mar 15, 2024

Uh oh!

polina-c commented Mar 15, 2024

Uh oh!

hannah-hyj commented Mar 15, 2024 •

edited

Loading

Uh oh!

hannah-hyj commented Mar 15, 2024 •

edited

Loading

Uh oh!

hannah-hyj left a comment

Uh oh!

hannah-hyj Mar 15, 2024

Uh oh!

anisovdev Mar 16, 2024

Uh oh!

anisovdev commented Mar 16, 2024

Uh oh!

auto-submit bot commented Mar 20, 2024

Uh oh!

hannah-hyj commented Mar 20, 2024

Uh oh!

anisovdev commented Mar 27, 2024

Uh oh!

anisovdev commented Mar 28, 2024 •

edited

Loading

Uh oh!

Uh oh!

[go_router]: fix GoRouter.optionURLReflectsImperativeAPIs flag works with new imperative APIs #6236

[go_router]: fix GoRouter.optionURLReflectsImperativeAPIs flag works with new imperative APIs #6236

Uh oh!

Conversation

anisovdev commented Mar 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

google-cla bot commented Mar 1, 2024

Uh oh!

anisovdev commented Mar 6, 2024

Uh oh!

anisovdev commented Mar 11, 2024

Uh oh!

anisovdev commented Mar 15, 2024

Uh oh!

polina-c commented Mar 15, 2024

Uh oh!

hannah-hyj commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hannah-hyj commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hannah-hyj left a comment

Choose a reason for hiding this comment

Uh oh!

hannah-hyj Mar 15, 2024

Choose a reason for hiding this comment

Uh oh!

anisovdev Mar 16, 2024

Choose a reason for hiding this comment

Uh oh!

anisovdev commented Mar 16, 2024

Uh oh!

auto-submit bot commented Mar 20, 2024

Uh oh!

hannah-hyj commented Mar 20, 2024

Uh oh!

anisovdev commented Mar 27, 2024

Uh oh!

anisovdev commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

anisovdev commented Mar 1, 2024 •

edited

Loading

hannah-hyj commented Mar 15, 2024 •

edited

Loading

hannah-hyj commented Mar 15, 2024 •

edited

Loading

anisovdev commented Mar 28, 2024 •

edited

Loading