Skip to content

[google_sign_in] Update README with instructions to use this package without Firebase #6292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

lukey78
Copy link

@lukey78 lukey78 commented Mar 9, 2024

There is some confusion about using this package without Firebase, especially for correctly integrating it with Android. The README update is based on the the following web resources:

List which issues are fixed by this PR. You must list at least one issue.

36673
33393
20903

There is some confusion about using this package without Firebase, especially for correctly integrating Android. Based on the the following web resources:
- flutter/flutter#20903
- https://medium.com/codebrew/flutter-google-sign-in-without-firebase-3680713966fb
@lukey78 lukey78 requested a review from stuartmorgan-g as a code owner March 9, 2024 20:29
Copy link

google-cla bot commented Mar 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@stuartmorgan-g
Copy link
Contributor

Thanks for the contribution, but this goes into a lot of details we wouldn't want to add to the README. E.g., explaining concepts like bundle IDs or the mechanics of Android app signing are well out of scope for the plugin, and would apply equally to non-Flutter applications. There are also a number of things here that would tend to become outdated very quickly, such as references to specific UI strings in external products.

This level of detail is probably best for something like a StackOverflow post, or a codelab. In the context of this README, what we would want is something much shorter and more evergreen, ideally consisting of links to the relevant official documentation for the wrapped SDKs. The only steps that we would want to cover in detail here would be anything specific to the Flutter plugin.

@lukey78
Copy link
Author

lukey78 commented May 5, 2024

Apparently - based on the vast amount of issues and articles regarding this issue - it seems that many people struggle with using the plugin without Firebase. I think the docs should tell something about the correct usage. And of course all of that is related to the Flutter plugin - this plugin seems to be the only way to make Google Sign In to work with Flutter. The standard OAuth2/OIDC plugins like flutter_web_auth_2 will not work anymore due to the deprecation of custom URI schemes.

@stuartmorgan-g
Copy link
Contributor

I think the docs should tell something about the correct usage.

We agree, which is why flutter/flutter#36673 is open. I'd be happy to review a PR along the lines of what I described at the end of my comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants