Skip to content

[pigeon]Add hellohuanlin to pigeon iOS for code reviews #6333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

hellohuanlin
Copy link
Contributor

So that I get notified for code reviews. I am mainly interested in Swift codegen.

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@hellohuanlin hellohuanlin requested a review from tarrinneal March 14, 2024 21:32
@hellohuanlin hellohuanlin added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 15, 2024
@auto-submit auto-submit bot merged commit 0a49d24 into main Mar 15, 2024
@auto-submit auto-submit bot deleted the hellohuanlin-patch-2 branch March 15, 2024 19:24
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 18, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 18, 2024
flutter/packages@756dcc1...a757073

2024-03-17 [email protected] Roll Flutter from 71606af to 7c860dd (21 revisions) (flutter/packages#6345)
2024-03-16 [email protected] [pointer_interceptor_web] Skip broken semantics tests and do a manual roll (flutter/packages#6342)
2024-03-15 [email protected] [pigeon]Add hellohuanlin to pigeon iOS for code reviews (flutter/packages#6333)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
So that I get notified for code reviews. I am mainly interested in Swift codegen. 

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants