-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[in_app_purchase] Replaced deprecated ProrationMode with ReplacementMode #6403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I had to update the versions in both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vongrad It looks like you are changing the name of the ProrationMode
class. This is a breaking change for the Android implementation, so it would need a major version bump (e.g. 0.4.0) if that is the goal of the PR.
Also, you are bumping the android implementation in packages/in_app_purchase/in_app_purchase/pubspec.yaml
, but that version doesn't exist on pub.dev
until this PR would land.
But overall I think we should actually deprecate ProrationMode
on the Dart side and add ReplacementMode
as a separate enum. And add it as a separate parameter in launchBillingFlow
. This would give users time to transition without breaking them immediately.
Since this looks like it is only changing an Android specific method, you shouldn't need to change in_app_purchase
in this PR.
@bparrishMines I agree that its probably better to introduce a new enum for |
Since this is adding a new feature, this should bump |
Sure thing, I will submit a new PR during next week once I get some free time. |
I made a new PR with the mentioned changes and in general re-worked it a bit. Please see here: #6515 |
…s billing client (#6515) Introduced new `ReplacementMode` for Android's billing client and deprecated `ProrationMode`. This PR is a follow-up on [https://github.com/flutter/packages/pull/6403](https://github.com/flutter/packages/pull/6403), where it was decided that we should not replace the `ProrationMode` with `ReplacementMode`, but instead only deprecate `ProrationMode`. The reason for a new PR is also that `in_app_purchase_android` version `0.3.3` changed internal platform communication to Pigeon, which meant I had to make major changes to my original PR. *List which issues are fixed by this PR. You must list at least one issue.* flutter/flutter#128957
…s billing client (flutter#6515) Introduced new `ReplacementMode` for Android's billing client and deprecated `ProrationMode`. This PR is a follow-up on [https://github.com/flutter/packages/pull/6403](https://github.com/flutter/packages/pull/6403), where it was decided that we should not replace the `ProrationMode` with `ReplacementMode`, but instead only deprecate `ProrationMode`. The reason for a new PR is also that `in_app_purchase_android` version `0.3.3` changed internal platform communication to Pigeon, which meant I had to make major changes to my original PR. *List which issues are fixed by this PR. You must list at least one issue.* flutter/flutter#128957
Replace deprecated
ProrationMode
in Android's billing client withReplacementMode
.List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#128957
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.md
to add a description of the change, [following repository CHANGELOG style].///
).