Skip to content

[quick_actions] Add Swift Package Manager support #6682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 10, 2024

Conversation

stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented May 7, 2024

Adds SPM support. Does not include any package changes, to maintain compatibility with stable.

Also adds a missing import in a test; it looks like it was probabl/y compiling before due to bleed-through from the Cocoapod dependency, and switching to SPM broke it. The test references a UIKit type, so should definitely have been importing it.

Fixes flutter/flutter#146915

Pre-launch Checklist

Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs some formatting tweaks

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label May 10, 2024
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit bot merged commit f1ca81a into flutter:main May 10, 2024
78 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 13, 2024
flutter/packages@6c4482a...1412041

2024-05-13 [email protected] [in_app_purchase] Update country code Android example (flutter/packages#6722)
2024-05-13 [email protected] Roll Flutter from 1dfb46e to 1255435 (6 revisions) (flutter/packages#6723)
2024-05-13 [email protected] [camera] Change default Android implementation from `camera_android` to `camera_android_camerax` (flutter/packages#6629)
2024-05-13 [email protected] [image_picker_ios] Make all headers public for SwiftPM to keep inline with CocoaPods (flutter/packages#6707)
2024-05-12 [email protected] Roll Flutter from 2aa05c1 to 1dfb46e (3 revisions) (flutter/packages#6715)
2024-05-11 [email protected] Roll Flutter from 2bfb1b0 to 2aa05c1 (26 revisions) (flutter/packages#6713)
2024-05-10 [email protected] [quick_actions] Add Swift Package Manager support (flutter/packages#6682)
2024-05-10 [email protected] [url_launcher] Add Swift Package Manager support (flutter/packages#6677)
2024-05-10 [email protected] [Android][webview_flutter] Run integration tests on emulators running Android 34 (flutter/packages#6499)
2024-05-10 [email protected] [image_picker_android] - will fix crash on Android 12+ devices (flutter/packages#6691)
2024-05-10 [email protected] [camerax] Make fixes required to swap camera_android_camerax for camera_android (flutter/packages#6697)
2024-05-10 [email protected] Update .gitignore for Swift Package Manager (flutter/packages#6705)
2024-05-10 [email protected] [quick_actions_android] Switch to `Compat` version of `ShortcutManager` to support Google surfaces (flutter/packages#6638)
2024-05-10 [email protected] [local_auth_darwin] Adds Swift Package Manager compatibility (flutter/packages#6708)
2024-05-10 [email protected] Roll Flutter from 00f4066 to 2bfb1b0 (9 revisions) (flutter/packages#6706)
2024-05-09 [email protected] [go_router] Feat add route redirect shellroutes (#114559) (flutter/packages#6432)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
Adds SPM support. Does not include any package changes, to maintain compatibility with `stable`.

Also adds a missing `import` in a test; it looks like it was probabl/y compiling before due to bleed-through from the Cocoapod dependency, and switching to SPM broke it. The test references a UIKit type, so should definitely have been importing it.

Fixes flutter/flutter#146915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: quick_actions platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[quick_actions_ios] Add Swift Package Manager compatibility to quick_actions_ios
2 participants