Skip to content

[flutter_adaptive_scaffold] Add additional slot animation parameters #6957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jamiewest
Copy link

Slots can currently be animated in and out of view, but there is not an ability to change the duration or curves of these animations. This PR adds additional parameters that are passed to the underlying AnimatedSwitcher when switching slots in and out of view.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jamiewest jamiewest requested a review from gspencergoog as a code owner June 20, 2024 17:28
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@gspencergoog
Copy link
Contributor

@jamiewest Thanks for the PR! Seems like a good addition.

As the bot mentioned, however, it will need to have tests before I can review it, according to our Tree Hygiene guide.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft July 16, 2024 19:56
@stuartmorgan-g
Copy link
Contributor

Marking as a draft since per the comment above this is not yet ready for review. Please mark it as ready once the tests have been added. Thanks!

@martijn00
Copy link
Contributor

Does this implement flutter/flutter#114272 ?

@martijn00
Copy link
Contributor

@gspencergoog after my other 2 PRs are merged i'll pick this up and add some tests. Should be good to take in for the next release as well.

auto-submit bot pushed a commit that referenced this pull request Sep 13, 2024
…#7411)

Slots can currently be animated in and out of view, but there is not an ability to change the duration or curves of these animations. This PR adds additional parameters that are passed to the underlying AnimatedSwitcher when switching slots in and out of view.

*List which issues are fixed by this PR. You must list at least one issue.*

#6957
@stuartmorgan-g
Copy link
Contributor

Since this is marked as a draft and hasn't been updated in several months I'm going to close it to clean out our review queue. Please don't hesitate to submit a new PR if you decide to revisit this. Thanks!

@martijn00
Copy link
Contributor

@stuartmorgan this was fixed and closed through #7411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants