Update web_benchmarks package to properly support wasm.
#6970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
requested changes
Jun 24, 2024
packages/web_benchmarks/CHANGELOG.md
Outdated
|
|
||
| * Updates minimum supported SDK version to Flutter 3.16/Dart 3.2. | ||
| * Support for running benchmarks with the wasm compilation target. |
There was a problem hiding this comment.
"Adds support for [...]", per the repo CHANGELOG style guide.
| @@ -7,11 +7,15 @@ | |||
| /// This object holds metadata that is used to determine how the benchmark app | |||
| /// should be built. | |||
| class CompilationOptions { | |||
| /// Creates a [CompilationOptions] object. | |||
| const CompilationOptions({ | |||
There was a problem hiding this comment.
Removing a constructor from a publicly exported class is a breaking change, and all of our packages follow semver. If you want to remove this, the package needs a major version bump.
|
|
||
| * Updates minimum supported SDK version to Flutter 3.16/Dart 3.2. | ||
| * Adds support for running benchmarks with the wasm compilation target. | ||
|
|
There was a problem hiding this comment.
This needs a description of the breaking changes; see https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
stuartmorgan-g
approved these changes
Jun 25, 2024
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 28, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 28, 2024
flutter/packages@03f5f6d...412ec46 2024-06-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.6 to 3.25.10 (flutter/packages#6924) 2024-06-27 [email protected] [video_player] Exposes VideoPlayerWebOptions. (flutter/packages#6990) 2024-06-27 [email protected] [ci] Add Wasm compilation to all_packages web app. (flutter/packages#6981) 2024-06-27 [email protected] [interactive_media_ads] Updates `README` with a usage section and fix some interface docs (flutter/packages#6988) 2024-06-27 [email protected] [tools] Fix vm test requirement (flutter/packages#6995) 2024-06-27 [email protected] Update `web_benchmarks` package to properly support wasm. (flutter/packages#6970) 2024-06-27 [email protected] [pigeon] Implement equals for Java data classes (flutter/packages#6992) 2024-06-25 [email protected] Final refactor of `video_player_android` before `SurfaceProducer#setCallback`. (flutter/packages#6982) 2024-06-25 [email protected] [pigeon] Update testing and docs (flutter/packages#6984) 2024-06-25 [email protected] [various] Update flutter.dev links to more reliable destinations (flutter/packages#6963) 2024-06-25 [email protected] [interactive_media_ads] Adds initial Android implementation (flutter/packages#6733) 2024-06-25 [email protected] Roll Flutter from 6c06abb to e726eb4 (51 revisions) (flutter/packages#6987) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jul 8, 2024
flutter/packages@03f5f6d...412ec46 2024-06-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.6 to 3.25.10 (flutter/packages#6924) 2024-06-27 [email protected] [video_player] Exposes VideoPlayerWebOptions. (flutter/packages#6990) 2024-06-27 [email protected] [ci] Add Wasm compilation to all_packages web app. (flutter/packages#6981) 2024-06-27 [email protected] [interactive_media_ads] Updates `README` with a usage section and fix some interface docs (flutter/packages#6988) 2024-06-27 [email protected] [tools] Fix vm test requirement (flutter/packages#6995) 2024-06-27 [email protected] Update `web_benchmarks` package to properly support wasm. (flutter/packages#6970) 2024-06-27 [email protected] [pigeon] Implement equals for Java data classes (flutter/packages#6992) 2024-06-25 [email protected] Final refactor of `video_player_android` before `SurfaceProducer#setCallback`. (flutter/packages#6982) 2024-06-25 [email protected] [pigeon] Update testing and docs (flutter/packages#6984) 2024-06-25 [email protected] [various] Update flutter.dev links to more reliable destinations (flutter/packages#6963) 2024-06-25 [email protected] [interactive_media_ads] Adds initial Android implementation (flutter/packages#6733) 2024-06-25 [email protected] Roll Flutter from 6c06abb to e726eb4 (51 revisions) (flutter/packages#6987) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the web_benchmarks package so it can compile and run apps with wasm. It also updates our CI steps to use a newer version of Chrome so that WasmGC works properly.