[camera_web] Migrate to `package:web` #7012

Rexios80 · 2024-06-28T19:13:23Z

Fixes flutter/flutter#139748

Notes:

Some fields are no longer nullable in package:web. We need to decide if we want to make them nullable again.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Rexios80 · 2024-06-28T20:36:37Z

I figured out how to run the tests compiled to WASM. Working on resolving the issues.

Rexios80 · 2024-06-29T00:22:08Z

Alright I think all the tests pass when compiled to WASM now

Rexios80 · 2024-06-29T00:34:43Z

The example app is having this issue: flutter/flutter#146539

ditman · 2024-06-29T03:14:06Z

I figured out how to run the tests compiled to WASM. Working on resolving the issues.

@Rexios80 Please describe? :)

Rexios80 · 2024-06-29T03:18:20Z

@ditman it's just flutter drive -d chrome --wasm

Probably requires master channel

Rexios80 · 2024-07-11T20:39:19Z

This is just a reminder to myself to merge with main and update https://github.com/flutter/packages/blob/main/script/configs/exclude_all_packages_app_wasm.yaml to remove this plugin from the exclusions

(away from dev computer right now)

ditman · 2024-07-11T22:16:03Z

Will work on this next, will try to get the update with main done and review locally. Thanks @Rexios80!

This reverts commit bfb2230.

ditman · 2024-07-12T02:11:43Z

Force-pushed the rebase, but I think I broke:

integration_test/zoom_level_capability_test.dart is being served at http://localhost:7357

It seems to be timing out :/

Rexios80 · 2024-07-12T04:27:47Z

I'm not sure what the Flutter team's policy is for rebase vs merge commits but I much prefer merge commits for the future if that's okay with you. It appears that the rebase invalidated my commit signing and we also lost easy access to the old CI runs.

Rexios80 · 2024-07-12T18:53:48Z

@ditman It runs fine for me individually

ditman

LGTM! I think this is good to go. Some pending changes have an associated issue so we don't forget to tackle them later.

kevmoo · 2024-08-05T23:19:14Z

autosubmit?

kevmoo

@ditman changes LGTM!

packages/camera/camera_web/example/integration_test/camera_service_test.dart

…migration-2

ditman · 2024-08-06T00:46:15Z

The failed test was a flake, I'll keep an eye on this to ensure it lands by EOD today.

Rexios80 · 2024-08-06T00:51:49Z

@ditman is there an issue to track the Mac_arm64 flakes?

ditman · 2024-08-06T00:55:32Z

@ditman is there an issue to track the Mac_arm64 flakes?

@Rexios80 can't remember off the top of my head, but mitigating them is definitely very high in the list of priorities of the team (there was a discord thread not too long ago).

flutter/packages@82e8d1e...551bde5 2024-08-06 [email protected] Manual roll Flutter from 3832823 to 1dd7141 (21 revisions) (flutter/packages#7317) 2024-08-06 [email protected] [google_maps_flutter_web] Web changes to support heatmaps (flutter/packages#7315) 2024-08-06 [email protected] [google_maps_flutter_ios] iOS changes to support heatmaps (flutter/packages#7314) 2024-08-06 [email protected] [google_maps_flutter_android] Android changes to support heatmaps (flutter/packages#7313) 2024-08-06 [email protected] [camera_web] Migrate to `package:web` (flutter/packages#7012) 2024-08-06 [email protected] [go_router_builder] Fixes readme typos and uses code excerpts. (flutter/packages#7280) 2024-08-05 [email protected] [go_router] redirect example signature fix (flutter/packages#7278) 2024-08-05 [email protected] [google_maps_flutter_platform_interface] Platform interface changes to support heatmaps (flutter/packages#7312) 2024-08-05 [email protected] [pointer_interceptor] Add performance warning on using pointer interceptor on iOS (flutter/packages#7288) 2024-08-05 [email protected] Roll Flutter from cbfb222 to 3832823 (4 revisions) (flutter/packages#7316) 2024-08-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.4 to 4.3.5 (flutter/packages#7308) 2024-08-05 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7302) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Rexios80 requested review from ditman and bparrishMines as code owners June 28, 2024 19:13

github-actions bot added p: camera platform-web labels Jun 28, 2024

Rexios80 added 14 commits July 11, 2024 18:14

Squash

fda6409

Fixing issues

83e183c

Fixing CI issues

fc97336

Refactoring mocked functions to JSFunction

04fcf95

Fixing tests

6f16798

Fixing tests

d28199a

...

18ad29d

...

70790a0

Revert "..."

4caa695

This reverts commit bfb2230.

...

252737a

...

bf29b16

Fix another test

0bc840f

Update flutter version constraints and set platform view height/width

3c95d15

Update Flutter version constraint again

04610ce

ditman force-pushed the feature/camera-web-migration-2 branch from ab44aff to 04610ce Compare July 12, 2024 02:10

Rexios80 mentioned this pull request Jul 12, 2024

Update packages repo web integration test examples index.html files to support WASM flutter/flutter#151663

Closed

7 tasks

ditman approved these changes Aug 5, 2024

View reviewed changes

kevmoo approved these changes Aug 5, 2024

View reviewed changes

Rexios80 commented Aug 5, 2024

View reviewed changes

packages/camera/camera_web/example/integration_test/camera_service_test.dart Outdated Show resolved Hide resolved

Rexios80 added 3 commits August 5, 2024 19:44

Merge remote-tracking branch 'upstream/main' into feature/camera-web-…

a8ba0cd

…migration-2

Formatting

7329278

Add trailing commas

0c60ea4

ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2024

This comment was marked as outdated.

Sign in to view

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024

ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024

This comment was marked as outdated.

Sign in to view

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024

Rexios80 added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024

This comment was marked as outdated.

Sign in to view

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024

ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024

This comment was marked as outdated.

Sign in to view

Rexios80 added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024

auto-submit bot merged commit cfbcc94 into flutter:main Aug 6, 2024
76 checks passed

engine-flutter-autoroll mentioned this pull request Aug 6, 2024

Roll Packages from 82e8d1eecb45 to 551bde53f6ea (12 revisions) flutter/flutter#152930

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 6, 2024

cfbcc94 [camera_web] Migrate to package:web (flutter/packages#7012)

765a4d0

ditman mentioned this pull request Sep 10, 2024

[camera_web] Don't require enumerating cameras on web #6369

Closed

11 tasks

[camera_web] Migrate to package:web #7012

[camera_web] Migrate to package:web #7012

Uh oh!

Conversation

Rexios80 commented Jun 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Rexios80 commented Jun 28, 2024

Uh oh!

Rexios80 commented Jun 29, 2024

Uh oh!

Rexios80 commented Jun 29, 2024

Uh oh!

ditman commented Jun 29, 2024

Uh oh!

Rexios80 commented Jun 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rexios80 commented Jul 11, 2024

Uh oh!

ditman commented Jul 11, 2024

Uh oh!

ditman commented Jul 12, 2024

Uh oh!

Rexios80 commented Jul 12, 2024

Uh oh!

Rexios80 commented Jul 12, 2024

Uh oh!

ditman left a comment

Choose a reason for hiding this comment

Uh oh!

kevmoo commented Aug 5, 2024

Uh oh!

kevmoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

ditman commented Aug 6, 2024

Uh oh!

This comment was marked as outdated.

Rexios80 commented Aug 6, 2024

Uh oh!

ditman commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

Uh oh!

[camera_web] Migrate to `package:web` #7012

[camera_web] Migrate to `package:web` #7012

Rexios80 commented Jun 28, 2024 •

edited

Loading

Rexios80 commented Jun 29, 2024 •

edited

Loading

ditman commented Aug 6, 2024 •

edited

Loading