[flutter_migrate] Remove one set of parens that wrap a single String literal #7216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e cases in `unnecessary_parenthesis`. `('text') * 2` is one such case. This change is being made in https://dart-review.googlesource.com/c/sdk/+/376540. (These are the only newly-reported unnecessary parentheses for this change.)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 26, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 26, 2024
flutter/packages@19daf6f...3d358d9 2024-07-26 [email protected] [many] Ignore NewerVersionAvailable in android lint (flutter/packages#7218) 2024-07-25 [email protected] [tool] Adds `--wasm` flag to the `drive-examples` command (flutter/packages#7162) 2024-07-25 [email protected] [tool] Add a package-level pre-publish hook (flutter/packages#7156) 2024-07-25 [email protected] [flutter_migrate] Remove one set of parens that wrap a single String literal (flutter/packages#7216) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
flutter/packages@19daf6f...3d358d9 2024-07-26 [email protected] [many] Ignore NewerVersionAvailable in android lint (flutter/packages#7218) 2024-07-25 [email protected] [tool] Adds `--wasm` flag to the `drive-examples` command (flutter/packages#7162) 2024-07-25 [email protected] [tool] Add a package-level pre-publish hook (flutter/packages#7156) 2024-07-25 [email protected] [flutter_migrate] Remove one set of parens that wrap a single String literal (flutter/packages#7216) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@19daf6f...3d358d9 2024-07-26 [email protected] [many] Ignore NewerVersionAvailable in android lint (flutter/packages#7218) 2024-07-25 [email protected] [tool] Adds `--wasm` flag to the `drive-examples` command (flutter/packages#7162) 2024-07-25 [email protected] [tool] Add a package-level pre-publish hook (flutter/packages#7156) 2024-07-25 [email protected] [flutter_migrate] Remove one set of parens that wrap a single String literal (flutter/packages#7216) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to address dart-lang/sdk#59144, we are reporting a few more cases in
unnecessary_parenthesis.('text') * 2is one such case. This change is being made in https://dart-review.googlesource.com/c/sdk/+/376540. (These are the only newly-reported unnecessary parentheses for this change.)This is the same change as flutter/flutter#152031
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.