Skip to content

[interactive_media_ads] Adds internal wrapper for iOS native IMACompanionAd #7873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 17, 2024

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Oct 14, 2024

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines bparrishMines changed the title Ima ios companion ad [interactive_media_ads] Adds internal wrapper for iOS native IMACompanionAd Oct 14, 2024
@bparrishMines bparrishMines marked this pull request as ready for review October 15, 2024 20:53
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 17, 2024
@auto-submit auto-submit bot merged commit a99f9e6 into flutter:main Oct 17, 2024
76 checks passed
@bparrishMines bparrishMines deleted the ima_ios_companion_ad branch October 17, 2024 19:10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 18, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 18, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 18, 2024
flutter/packages@5582669...2a1c477

2024-10-18 [email protected] [camera_android] Convert Dart to native calls to use Pigeon (flutter/packages#7874)
2024-10-17 [email protected] [url_launcher] Decode file URLs before passing it to ShellExecuteW (flutter/packages#7774)
2024-10-17 [email protected] [in_app_purchase_storekit] Add support for purchase and transactions (flutter/packages#7887)
2024-10-17 [email protected] [interactive_media_ads] Adds internal wrapper for iOS native `IMACompanionAd` (flutter/packages#7873)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: interactive_media_ads Plugin for IMA SDK platform-android platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants