-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[ci] Run web tests in wasm (unit + integration). #8111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
a1d0b38
Add a --wasm test shard in master.
ditman 9f4cd1f
Add web_platform_tests_wasm config. Copy that config to non-wasm vers…
ditman b518877
Remove extra comma
ditman 0f80fcb
url_launcher_web tests now pass with --wasm
ditman 1542405
video_player tests now pass with --wasm
ditman 1685463
pointer_interceptor_web wasm tests now pass.
ditman b56ac8d
Exclude file_selector, since it does not have integration tests.
ditman c510654
Attempt to pass multiple exclusion files, similarly to how we exclude…
ditman bcd7f6f
google_maps_flutter_web tests now pass in wasm
ditman 01a9321
dart format .
ditman 6b01a26
Remove unnecessary import.
ditman be17b43
Clarify note
ditman 9c10258
Shard wasm tests in 3 shards.
ditman 8bb9e64
Try prebuilding the examples.
ditman 18674b3
Do not prebuild apps. Integration tests on the web work by building a…
ditman 598ed80
Update animations/example gitignore file.
ditman 630bfe6
Merge branch 'main' into run-web-integration-wasm
ditman dc40e4d
Merge branch 'flutter:main' into run-web-integration-wasm
ditman 67d7897
google_adsense Fix experimental test so it passes in wasm.
ditman b579c4e
Test if we need to prebuild the examples or not on the web.
ditman 9afe55e
Restore JS test yaml
ditman 54606d0
Stop prebuilding web examples
ditman 00a67f7
Merge branch 'main' into run-web-integration-wasm
ditman 6bd249e
Run web unit tests with Wasm as well.
ditman 13ca07c
Adds support for --wasm to dart_test_command.
ditman c04f01b
[image_picker] Migrate internal PickedFile to Wasm.
ditman 6324f8d
[vector_graphics_codec] Tests now pass in wasm.
ditman d9a8aa3
[rfw] Make RFW tests pass in wasm.
ditman 70d4de8
Try unit_tests_wasm exceptions file.
ditman 5ade435
Revert non-wasm unit test ci target
ditman 6660cfb
Remove unneeded comment from gitignore
ditman fcaff2a
Merge branch 'main' into run-web-integration-wasm
ditman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
tasks: | ||
- name: prepare tool | ||
script: .ci/scripts/prepare_tool.sh | ||
infra_step: true # Note infra steps failing prevents "always" from running. | ||
- name: Dart unit tests - web (wasm) | ||
script: .ci/scripts/tool_runner.sh | ||
args: [ | ||
"dart-test", | ||
"--platform=chrome", | ||
"--wasm", | ||
"--exclude=script/configs/dart_unit_tests_exceptions.yaml", | ||
"--exclude=script/configs/dart_unit_tests_wasm_exceptions.yaml" | ||
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
tasks: | ||
- name: prepare tool | ||
script: .ci/scripts/prepare_tool.sh | ||
infra_step: true # Note infra steps failing prevents "always" from running. | ||
- name: download Dart deps | ||
script: .ci/scripts/tool_runner.sh | ||
args: ["fetch-deps", "--web", "--supporting-target-platforms-only"] | ||
infra_step: true | ||
- name: drive examples | ||
script: .ci/scripts/tool_runner.sh | ||
args: [ | ||
"drive-examples", | ||
"--web", | ||
"--wasm", | ||
"--run-chromedriver", | ||
"--exclude=script/configs/exclude_integration_web.yaml", | ||
"--exclude=script/configs/exclude_integration_web_wasm.yaml" | ||
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
packages/image_picker/image_picker_platform_interface/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talk to @eyebrowsoffire about this new delay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed this, the skwasm renderer is now async, so it makes sense that there's some timing differences compared to the JS one. Needing this additional delay is probably caused by the
tester
not being aware of this asynchronicity, and declaring a frame "pumped" before it's really been fully rendered.