[webview_flutter_android] Add additional WebSettings methods #8270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… setAllowContentAccess, setGeolocationEnabled, setCacheMode
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
bparrishMines
requested changes
Jan 7, 2025
There was a problem hiding this comment.
As I stated in flutter/flutter#160070, I think this PR should remove support for setCacheMode in favor of a platform interface method. The implementation of the other methods look fine to me.
|
@bparrishMines I've removed the |
bparrishMines
added
the
autosubmit
|
auto label is removed for flutter/packages/8270, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
auto-submit
bot
removed
the
autosubmit
|
@stuartmorgan or @flutter/android-reviewers For secondary review. @westracer Updates to the iOS implementation is still waiting on #8311 to land, so I would hold off on the iOS side of |
bparrishMines
approved these changes
Jan 9, 2025
Co-authored-by: Maurice Parrish <[email protected]>
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 14, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 14, 2025
flutter/packages@3c3bc68...d1fd623 2025-01-13 [email protected] [camera] Add API support query for image streaming (flutter/packages#8250) 2025-01-13 [email protected] [webview_flutter_android] Add additional WebSettings methods (flutter/packages#8270) 2025-01-13 [email protected] Roll Flutter from 864d4f5 to 72db8f6 (11 revisions) (flutter/packages#8421) 2025-01-13 [email protected] [video_player_avfoundation, camera_avfoundation] never overwrite but only upgrade audio session category (flutter/packages#7143) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
maheshj01
pushed a commit
to maheshj01/flutter
that referenced
this pull request
Jan 15, 2025
…r#161597) flutter/packages@3c3bc68...d1fd623 2025-01-13 [email protected] [camera] Add API support query for image streaming (flutter/packages#8250) 2025-01-13 [email protected] [webview_flutter_android] Add additional WebSettings methods (flutter/packages#8270) 2025-01-13 [email protected] Roll Flutter from 864d4f5 to 72db8f6 (11 revisions) (flutter/packages#8421) 2025-01-13 [email protected] [video_player_avfoundation, camera_avfoundation] never overwrite but only upgrade audio session category (flutter/packages#7143) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes native WebSettings such as setAllowContentAccess and setGeolocationEnabled in order to give developers more options to configure the native webview and restrict these features that are enabled by default.
Fixes 160070
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.