Skip to content

[camera_android_camerax][video_player_android] Suppresses deprecation of the SurfaceProducer.Callback.onSurfaceDestroyed method #8388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Jan 7, 2025

See flutter/flutter#161256

This was causing errors with the Flutter->Packages roller:

> Task :camera_android_camerax:compileDebugJavaWithJavac
/b/s/w/ir/x/w/packages/packages/camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/PreviewHostApiImpl.java:92: warning: [removal] onSurfaceDestroyed() in Callback has been deprecated and marked for removal
              public void onSurfaceDestroyed() {
                          ^
error: warnings found and -Werror specified
1 error
1 warning

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines bparrishMines changed the title deprecation handling [camera_android_camerax][video_player_android] Suppresses deprecation of of SurfaceProducer.Callback methods Jan 7, 2025
@bparrishMines bparrishMines marked this pull request as ready for review January 7, 2025 20:28
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this invalidated by #8384?

@bparrishMines
Copy link
Contributor Author

bparrishMines commented Jan 7, 2025

@matanlurey I believe #8384 only updates onSurfaceCreated which requires 3.27. This PR updates onSurfaceDestroyed, which requires 3.28

I updated the title to specify the method.

@bparrishMines bparrishMines changed the title [camera_android_camerax][video_player_android] Suppresses deprecation of of SurfaceProducer.Callback methods [camera_android_camerax][video_player_android] Suppresses deprecation of the SurfaceProducer.Callback.onSurfaceDestroyed method Jan 7, 2025
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@stuartmorgan-g
Copy link
Contributor

test-exempt: fixes an existing test that is failing in the roll

@bparrishMines bparrishMines added override: no versioning needed Override the check requiring version bumps for most changes autosubmit Merge PR when tree becomes green via auto submit App labels Jan 7, 2025
@auto-submit auto-submit bot merged commit 0e189f7 into flutter:main Jan 7, 2025
77 checks passed
@bparrishMines bparrishMines deleted the surface_cleanup branch January 7, 2025 22:02
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2025
…eprecation of the `SurfaceProducer.Callback.onSurfaceDestroyed` method (flutter/packages#8388)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2025
…eprecation of the `SurfaceProducer.Callback.onSurfaceDestroyed` method (flutter/packages#8388)
auto-submit bot pushed a commit that referenced this pull request Jan 8, 2025
…x tests (#8391)

Manual roll to check that the test warning suppressions will fix roll.

I forgot to update the tests in #8388
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 9, 2025
…eprecation of the `SurfaceProducer.Callback.onSurfaceDestroyed` method (flutter/packages#8388)
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jan 9, 2025
flutter/packages@3fc6b7a...6554751

2025-01-09 [email protected] [webview_flutter_wkwebview] Add a
listener for the canGoBack property change on the iOS platform.
(flutter/packages#8203)
2025-01-09 [email protected] [flutter_svg]
Implement errorBuilder callback (flutter/packages#8364)
2025-01-08 [email protected]
[interactive_media_ads] Adds remaining methods for internal wrapper of
the iOS native `IMAAdDisplayContainer`. (flutter/packages#8153)
2025-01-08 [email protected] [go_router_builder] Add a fallback for
a not null List or Set param (flutter/packages#8349)
2025-01-08 [email protected] Manual roll Flutter (stable)
from 8495dee to 17025dd (2 revisions) (flutter/packages#8396)
2025-01-08 [email protected]
[ci][video_player_android][camera_android_camerax] Manual roll and fix
tests (flutter/packages#8391)
2025-01-07 [email protected] [ci] Run web tests in wasm (unit +
integration). (flutter/packages#8111)
2025-01-07 [email protected] [camera_platform_interface] Add API support query
for image streaming (flutter/packages#8307)
2025-01-07 [email protected]
[camera_android_camerax][video_player_android] Suppresses deprecation of
the `SurfaceProducer.Callback.onSurfaceDestroyed` method
(flutter/packages#8388)
2025-01-07 [email protected] Bump Remaining Plugin Example Apps to
targetSdkVersion >= 34 and compileSdkVersion >= 34
(flutter/packages#8361)
2025-01-07 [email protected] Replace
`onSurfaceCreated` with `onSurfaceAvailable`. (flutter/packages#8384)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no versioning needed Override the check requiring version bumps for most changes p: camera p: video_player platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants