-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[video_player_android] Platform view support #8466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 60 commits into
flutter:main
from
leancodepl:feature/video-player-android-platform-view-support
Mar 4, 2025
Merged
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
15a0d09
Add platform interface changes
FirentisTFW 25520fc
Add platform view support for Android
FirentisTFW 28d38c5
Rearrange native unit tests after merge
FirentisTFW 0d3a753
Remove a todo in web implementation
FirentisTFW ea16d63
Set initial value of nextNonTexturePlayerId to Long.MAX_VALUE
FirentisTFW 25425ca
Use player provider instead of modifiable list
FirentisTFW ce2aa51
Remove empty line
FirentisTFW 8aeca10
Check player view states in Dart unit tests
FirentisTFW 209f34f
Restore previous formatting for comments
FirentisTFW 42cb659
Add missing licenses
FirentisTFW 690ec54
Format files
FirentisTFW 6db9e6d
Fix linting issues
FirentisTFW 277bff7
Rename textureId to playerId in platform interace methods
FirentisTFW 5aca5db
Rename textureId to playerId in Android Dart files
FirentisTFW 751d529
Rename textureId to playerId in Android native code
FirentisTFW e6f856b
Add an ignore to UI test (it times out on Firebase Test Lab)
FirentisTFW b752b4c
Merge branch 'main' into feature/video-player-android-platform-view-s…
FirentisTFW 8fc1fa0
Bump platform interface dependency to 6.3.0
FirentisTFW b745dcc
Remove resolved todo and fix dartdocs
FirentisTFW 773cfc1
Add missing import
FirentisTFW 89dfcea
Format test file
FirentisTFW f59463a
Add more context to class names for native views
FirentisTFW 650cc21
Add missing docs for Android
FirentisTFW 18463e7
Format file
FirentisTFW 11647d0
Remove redundant async keyword
FirentisTFW 8f9ccd8
Depend on platform interface 6.3.0
FirentisTFW 0c2e19b
Add more details to javadocs for players
FirentisTFW 17d5c6c
Rename method for clarity
FirentisTFW 10640da
Remove "///" from a javadoc
FirentisTFW 7917c0c
Add unit tests for NativeVideoView and NativeVideoViewFactory
FirentisTFW 06b20a1
Add unit tests for VideoPlayerPlugin.create method
FirentisTFW 1e51f8c
Add empty line to separate concepts
FirentisTFW e2a5afa
Clean up newly added tests
FirentisTFW 2692564
Sort imports
FirentisTFW f5258df
Add missing licenses
FirentisTFW 1bbe2c2
Split ExoPlayerEventListener into two classes, for platform view and …
FirentisTFW f43e9ba
Make class final
FirentisTFW 22c9241
Use "PlatformView" instead of "NativeView" everywhere
FirentisTFW df3959d
Rename TextureBased to Texture, move texture player to a separate pac…
FirentisTFW 4575c4c
Make VideoPlayer abstract
FirentisTFW eae1eb5
Clean up analysis
FirentisTFW c39b14c
Rename nextNonTexturePlayerId to nextPlatformViewPlayerId
FirentisTFW 8d3279d
Split tests for exo player event listeners
FirentisTFW 2862323
Update implementation comment
FirentisTFW 314bf82
Use widget instead of a method
FirentisTFW feca35d
Move VideoPlayerProvider to PlatformVideoViewFactory
FirentisTFW 7956b19
Comment on swapping width and height
FirentisTFW 70ed428
Remove redundant abstract class method
FirentisTFW ce63f14
Handle SurfaceView on Android 9 correctly, document workarounds
FirentisTFW 81a71a3
Test output, not internal state
FirentisTFW 41891d2
Remove overriden == operator as it's not needed anymore
FirentisTFW 6bf34e7
Clean up code
FirentisTFW dc08e2d
Format code
FirentisTFW 0681400
Use custom test class in VideoPlayerTest
FirentisTFW b0f282d
Add missing licenses
FirentisTFW 6c17ebc
Add a todo to decouple identifiers in the future
FirentisTFW 9895676
Format file
FirentisTFW da1b78d
Resolve lint issues
FirentisTFW ae4bfae
Inline method
FirentisTFW 371c462
Format file
FirentisTFW File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.