Skip to content

[video_player_avfoundation] macOS platform view support #8558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 159 commits into
base: main
Choose a base branch
from

Conversation

FirentisTFW
Copy link
Contributor

[DRAFT]
This PR contains changes from #8237. Once that PR is merged (and video_player package is published with platform view support on iOS and Android), this PR will be rebased and adjusted. For now it will hang as a draft.

This PR will add platform view support to video_player package for macOS.

Pre-launch Checklist

@cbenhagen
Copy link
Contributor

@FirentisTFW now that #8237 has been merged, what's missing to add macOS support?

@FirentisTFW
Copy link
Contributor Author

@cbenhagen We wanted to fully release iOS and Android implementations first to have less potential pain points.

However, these were also not fully released yet. #8810 is adding the support to the app-facing package. I still haven't published it though, since it seems that there are some issues when rendering Android's SurfaceView (which is used by video_player_android) in Flutter. There's an issue for that: #164899. I was going to wait a little bit more for the Android team's input there before I try to work around it again. Only then I wanted to publish the app-facing PR and then follow up with the macOS support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants