Skip to content

[camera_avfoundation] Migrate tests to Swift - part 3 #8661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
5de2587
Migrate CameraCaptureSessionQueueRaceConditionTests to Swift
FirentisTFW Feb 11, 2025
a7b3c02
Migrate CameraMethodChannelTests to Swift
FirentisTFW Feb 11, 2025
c91bbae
Migrate CameraOrientationTests to Swift
FirentisTFW Feb 12, 2025
2608e45
Migrate CameraSettingsTests to Swift
FirentisTFW Feb 12, 2025
f261951
Migrate CameraSessionPresetsTests to Swift
FirentisTFW Feb 12, 2025
effbaae
Bump version and update changelog
FirentisTFW Feb 11, 2025
145ccd2
Remove redundant "any" keywords
FirentisTFW Feb 12, 2025
0f7eada
Merge branch 'main' into feature/camera-swift-test-migration-part2
FirentisTFW Feb 13, 2025
5464d73
Remove duplicated test file
FirentisTFW Feb 13, 2025
39334e1
Inlcude missing test file
FirentisTFW Feb 13, 2025
6989e86
Bump version and update changelog
FirentisTFW Feb 13, 2025
6725409
Resolve conflicts in bridging-header file
FirentisTFW Feb 13, 2025
0b51e01
Revert "Inlcude missing test file"
FirentisTFW Feb 13, 2025
ff8fd05
Migrate SavePhotoDelegateTests to Swift
FirentisTFW Feb 13, 2025
974e728
Clean up - Swift tests migration
FirentisTFW Feb 13, 2025
612c425
Sort imports
FirentisTFW Feb 13, 2025
29870d5
Clean up code
FirentisTFW Feb 13, 2025
828f73e
Remove shared state from CameraOrientationTests
FirentisTFW Feb 13, 2025
aa7c223
Merge branch 'main' into feature/camera-swift-test-migration-part2
FirentisTFW Feb 13, 2025
4b74842
Bump version
FirentisTFW Feb 13, 2025
3b2b4a9
Adjust code to the new API after merge
FirentisTFW Feb 13, 2025
75a58a0
Fix a comment
FirentisTFW Feb 13, 2025
b5743e7
Merge branch 'main' into feature/camera-swift-test-migration-part2
FirentisTFW Feb 17, 2025
4237804
Adjust code after merge
FirentisTFW Feb 17, 2025
a457cb2
Migrate ThreadSafeEventChannelTests to Swift
FirentisTFW Feb 14, 2025
e50b1f3
Migrate StreamingTests to Swift
FirentisTFW Feb 14, 2025
550a630
Migrate SampleBufferTests to Swift
FirentisTFW Feb 17, 2025
bcb050d
Migrate PhotoCaptureTests to Swift
FirentisTFW Feb 18, 2025
d7c6113
Move Objective-C files up in XCode
FirentisTFW Feb 18, 2025
f4fde53
Merge branch 'main' into feature/camera-swift-test-migration-part3
FirentisTFW Feb 19, 2025
6d20234
Remove "any" keyword
FirentisTFW Feb 20, 2025
882904a
Remove resolved fixme comment
FirentisTFW Feb 20, 2025
7b7a881
Clean up whitespacing
FirentisTFW Feb 20, 2025
f6b743f
Migrate MockWritableData to Swift
FirentisTFW Feb 20, 2025
808f21b
Migrate MockEventChannel to Swift
FirentisTFW Feb 20, 2025
21fe3ac
Add missing license
FirentisTFW Feb 20, 2025
b97d86a
Clean up mocks code
FirentisTFW Feb 20, 2025
50358ef
Use prefix for Objecive-C code
FirentisTFW Feb 23, 2025
9f2b3e7
Remove redundant return statement
FirentisTFW Feb 23, 2025
a4741a3
Put every argument in a separate line for long lists
FirentisTFW Feb 23, 2025
24d0175
Do not use ! in tests code
FirentisTFW Feb 23, 2025
887e487
Add a todo to verify if properties need to be nullable
FirentisTFW Feb 27, 2025
d189ba2
Move todo from mock to protocol
FirentisTFW Feb 27, 2025
18f1714
Remove todo and make parameters non-nullable
FirentisTFW Feb 27, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,11 @@ extern CMSampleBufferRef FLTCreateTestSampleBuffer(void);
/// @return a test audio sample buffer.
extern CMSampleBufferRef FLTCreateTestAudioSampleBuffer(void);

/// Calls `dispatch_queue_set_specific` with a key that is used to identify the queue.
/// This method is needed for comaptibility of Swift tests with Objective-C code.
/// In Swift, the API for settinng key-value pairs on a queue is different, so Swift tests
/// need to call this method to set the key-value pair on the queue in a way that's
/// compatible withn the existing Objective-C code.
extern void FLTdispatchQueueSetSpecific(dispatch_queue_t queue, const void *key);

NS_ASSUME_NONNULL_END
Original file line number Diff line number Diff line change
Expand Up @@ -127,3 +127,7 @@ CMSampleBufferRef FLTCreateTestAudioSampleBuffer(void) {
CFRelease(formatDescription);
return sampleBuffer;
}

void FLTdispatchQueueSetSpecific(dispatch_queue_t queue, const void *key) {
dispatch_queue_set_specific(queue, key, (void *)key, NULL);
}

This file was deleted.

Loading