Skip to content

[various] Updates packages to use flutter.compileSdkVersion #8734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 6, 2025
Merged

[various] Updates packages to use flutter.compileSdkVersion #8734

merged 13 commits into from
Mar 6, 2025

Conversation

reidbaker
Copy link
Contributor

  • Updates compileSdk 34 to flutter.compileSdkVersion.

Related to flutter/flutter/issues/149836
Want to wait a couple of days after
#8700 lands before landing.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@reidbaker reidbaker force-pushed the i149836-api-35-update-part-12 branch from 74580ef to 323fb10 Compare February 28, 2025 17:22
@reidbaker reidbaker force-pushed the i149836-api-35-update-part-12 branch from 323fb10 to 4ab44c4 Compare February 28, 2025 17:23
reidbaker
reidbaker commented Feb 28, 2025
View reviewed changes
packages/camera/camera_android_camerax/pubspec.yaml
@@ -2,7 +2,7 @@ name: camera_android_camerax
description: Android implementation of the camera plugin using the CameraX library.
repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android_camerax
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
version: 0.6.14
version: 0.6.14+1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might wonder why this plugin didnt need to update to 3.27. It is because it was already updated.

@reidbaker
Copy link
Contributor Author

Ignoring conflicts in changelog and pubspec until after approval since they will keep happening.

@reidbaker reidbaker marked this pull request as ready for review March 4, 2025 17:51
@reidbaker
Copy link
Contributor Author

I think the failure that i am seeing is flutter/flutter#164132

tarrinneal
tarrinneal approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good pigeon test change!

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025
@auto-submit auto-submit bot merged commit bfad6b9 into flutter:main Mar 6, 2025
83 checks passed
@reidbaker reidbaker deleted the i149836-api-35-update-part-12 branch March 6, 2025 15:50
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
bfad6b976 [various] Updates packages to use flutter.compileSdkVersion (…
1dc696b 
…flutter/packages#8734)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 7, 2025
Merged
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
Roll Packages from fc9d5ca9ceaa to 4c5a7ed11ea1 (4 revisions) (#164785)
1b14b0c 
flutter/packages@fc9d5ca...4c5a7ed

2025-03-07 [email protected] Update PR template for clarity
(flutter/packages#8777)
2025-03-06 [email protected] [google_sign_in] Add Android account name
field as optional (implementation package changes)
(flutter/packages#8805)
2025-03-06 [email protected] Roll Flutter from
2578d97 to 321fbc0 (29 revisions) (flutter/packages#8808)
2025-03-06 [email protected] [various] Updates packages to use
flutter.compileSdkVersion (flutter/packages#8734)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@ryanheise
Copy link

Maybe the plugin template should also implement this change too since it currently hardcodes compileSdk to 35 instead of flutter.compileSdkVersion.

Also, just a question about what you've done here. I can see in the example's android/app/build.gradle file that there is this explicit flutter block:

flutter {
    source '../..'
}

But in the plugin itself, the android/build.gradle file contains no such explicit flutter block, so I'm curious how the reference to flutter.compileSdkVersion is resolved. Is the idea that it is inherited from whatever app is being built? When I open the plugin in Android Studio, it has a problem resolving the reference to flutter.compileSdkVersion, yet apps will build fine from the command line.

Finally, I question whether this change might be considered as a breaking change, since other plugins or apps that depend on such a plugin that use compileSdk 34 might now stop during the build because the plugin requires compileSdk 35. Do we ignore that sort of thing when considering semantic versioning of plugins?

@reidbaker
Copy link
Contributor Author

"I question whether this change might be considered as a breaking change, since other plugins or apps that depend on such a plugin that use compileSdk 34 might now stop during the build because the plugin requires compileSdk 35. "

This change also set the minimum flutter verison to 3.27.0 that version of flutter is expecting to compiled with sdk 35. If you were running a version of flutter that expected sdk 34 then you would not get this change. In my mind that is why this is not a breaking change.

@gmackall gmackall mentioned this pull request Apr 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrinneal tarrinneal tarrinneal approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

@camsim99 camsim99 Awaiting requested review from camsim99 camsim99 is a code owner

@matanlurey matanlurey Awaiting requested review from matanlurey

@gmackall gmackall Awaiting requested review from gmackall gmackall is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera p: espresso p: file_selector p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: interactive_media_ads Plugin for IMA SDK p: local_auth p: path_provider p: pigeon p: quick_actions p: shared_preferences p: url_launcher p: video_player p: webview_flutter platform-android platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reidbaker @ryanheise @tarrinneal