[camera_avfoundation] Implementation swift migration - part 2 #9007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertOdrowaz
force-pushed
the
feature/camera-implementation-swift-migration-part2
branch
3 times, most recently
from
aa4269d to
8be6136
Compare
RobertOdrowaz
commented
Apr 16, 2025
| permissionManager: FLTCameraPermissionManager( | ||
| permissionService: FLTDefaultPermissionService()), | ||
| deviceFactory: { name in | ||
| FLTDefaultCaptureDevice(device: AVCaptureDevice(uniqueID: name)!) |
There was a problem hiding this comment.
I don't like the null assertion here, but it is consistent with the ObjC implementation behavior, and I don't want to go into the error handling improvements rabbit hole during the migration
RobertOdrowaz
commented
Apr 16, 2025
| @@ -13,3 +13,7 @@ void FLTEnsureToRunOnMainQueue(dispatch_block_t block) { | |||
| block(); | |||
| } | |||
| } | |||
|
|
|||
| void FLTDispatchQueueSetSpecific(dispatch_queue_t queue, const void *key) { | |||
There was a problem hiding this comment.
This function is moved from QeueueTestUtils. We now need it in CameraPlugin to access the ObjC dispatch queue API from Swift. It will be completely removed once FLTCam is migrated
RobertOdrowaz
force-pushed
the
feature/camera-implementation-swift-migration-part2
branch
from
8be6136 to
859ad13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates camera implementation as part of flutter/flutter#119109
This PR migrates
CameraPluginclass.Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3