[go_router_builder] Add caseSensitive to TypedGoRoute
#9096
+63
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinVignal
commented
Apr 16, 2025
There was a problem hiding this comment.
I'm not too convinced by the tests I wrote. Any idea for a better test?
There was a problem hiding this comment.
I think this is fine, the real test will be in the go_router_builder I think
chunhtai
approved these changes
Apr 21, 2025
There was a problem hiding this comment.
I think this is fine, the real test will be in the go_router_builder I think
chunhtai
added
the
autosubmit
11 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 22, 2025
flutter/packages@ac21f53...f1fc965 2025-04-22 [email protected] [vector_graphics_compiler] fix: Stroke opacity not applied (flutter/packages#8986) 2025-04-21 [email protected] [in_app_purchase] Write to the transactions update queue from the main thread (flutter/packages#9068) 2025-04-21 [email protected] [go_router_builder] Add `caseSensitive` to `TypedGoRoute` (flutter/packages#9096) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
…ute` (#9126) Part of flutter/flutter#167277 I missed this parameter in #9096. This PR adds it. After that, I'll be able to make a PR for go_router_builder ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
raju8000
pushed a commit
to raju8000/flutter_packages
that referenced
this pull request
Apr 26, 2025
First part of flutter/flutter#167277 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
raju8000
pushed a commit
to raju8000/flutter_packages
that referenced
this pull request
Apr 26, 2025
…ute` (flutter#9126) Part of flutter/flutter#167277 I missed this parameter in flutter#9096. This PR adds it. After that, I'll be able to make a PR for go_router_builder ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of flutter/flutter#167277
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3