Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Migrate to AndroidX forward roll #1128

Merged
merged 2 commits into from
Jan 28, 2019
Merged

Migrate to AndroidX forward roll #1128

merged 2 commits into from
Jan 28, 2019

Conversation

mklim
Copy link
Contributor

@mklim mklim commented Jan 28, 2019

This PR forward rolls the earlier breaking changes with a proper semantic version upgrade.

flutter/flutter#27128
flutter/flutter#23995

Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mklim pushed a commit that referenced this pull request Jan 28, 2019
The AndroidX migration didn't increment the major version for plugins >=
1.0.0. This commit reverts the code changes in the affected plugins.

It's critical that the forward roll PR is published with this so that clients
that have previously migrated aren't broken by the revert. I'm not planning
on merging this into master until the forward roll (#1128) is
also LGTMed and ready to merge.

flutter/flutter#27128
flutter/flutter#23995
Michael Klimushyn added 2 commits January 28, 2019 14:29
@mklim mklim merged commit 9d8a100 into flutter:master Jan 28, 2019
@mklim mklim deleted the forward_roll_androidx branch January 28, 2019 23:04
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
The AndroidX migration didn't increment the major version for plugins >=
1.0.0. This commit reverts the code changes in the affected plugins.

It's critical that the forward roll PR is published with this so that clients
that have previously migrated aren't broken by the revert. I'm not planning
on merging this into master until the forward roll (flutter#1128) is
also LGTMed and ready to merge.

flutter/flutter#27128
flutter/flutter#23995
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
This PR forward rolls the earlier breaking changes with a proper semantic version upgrade.

flutter/flutter#27128
flutter/flutter#23995
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
collinjackson pushed a commit to collinjackson/flutterfire-old2 that referenced this pull request Jun 24, 2019
The AndroidX migration didn't increment the major version for plugins >=
1.0.0. This commit reverts the code changes in the affected plugins.

It's critical that the forward roll PR is published with this so that clients
that have previously migrated aren't broken by the revert. I'm not planning
on merging this into master until the forward roll (flutter/plugins#1128) is
also LGTMed and ready to merge.

flutter/flutter#27128
flutter/flutter#23995
collinjackson pushed a commit to firebase/flutterfire that referenced this pull request Aug 14, 2019
The AndroidX migration didn't increment the major version for plugins >=
1.0.0. This commit reverts the code changes in the affected plugins.

It's critical that the forward roll PR is published with this so that clients
that have previously migrated aren't broken by the revert. I'm not planning
on merging this into master until the forward roll (flutter/plugins#1128) is
also LGTMed and ready to merge.

flutter/flutter#27128
flutter/flutter#23995
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
This PR forward rolls the earlier breaking changes with a proper semantic version upgrade.

flutter/flutter#27128
flutter/flutter#23995
nksteven pushed a commit to nksteven/ntf-firebase_messaging that referenced this pull request Apr 8, 2020
The AndroidX migration didn't increment the major version for plugins >=
1.0.0. This commit reverts the code changes in the affected plugins.

It's critical that the forward roll PR is published with this so that clients
that have previously migrated aren't broken by the revert. I'm not planning
on merging this into master until the forward roll (flutter/plugins#1128) is
also LGTMed and ready to merge.

flutter/flutter#27128
flutter/flutter#23995
henkibro pushed a commit to henkibro/url_launcher that referenced this pull request Mar 1, 2022
The AndroidX migration didn't increment the major version for plugins >=
1.0.0. This commit reverts the code changes in the affected plugins.

It's critical that the forward roll PR is published with this so that clients
that have previously migrated aren't broken by the revert. I'm not planning
on merging this into master until the forward roll (flutter/plugins#1128) is
also LGTMed and ready to merge.

flutter/flutter#27128
flutter/flutter#23995
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants