Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[shared_preferences] Added reload method #1198

Merged

Conversation

wouterhardeman
Copy link
Contributor

Resolves flutter/flutter#27490

The refreshCache() function clears the local cache and fetches the shared preferences from the host platform.

@bparrishMines bparrishMines added feature submit queue The Flutter team is in the process of landing this PR. and removed submit queue The Flutter team is in the process of landing this PR. labels Feb 22, 2019
@cyanglaz
Copy link
Contributor

Thank you for the contribution! The change looks good to me! Could you please rebase and resolve the conflicts? Also, could you add integration test for your new method? The integration tests should be in the example/test folder. Please refer to the contribution guide for running integration test locally. .

@wouterhardeman wouterhardeman force-pushed the shared-preferences-refresh-cache branch from d01dd90 to f37161e Compare May 13, 2019 13:22
@collinjackson collinjackson changed the title [shared_preferences] Added refreshCache method [shared_preferences] Added reload method May 31, 2019
@collinjackson
Copy link
Contributor

I think that reload() is shorter than refreshCache() and might make more sense (none of the other method names mention a cache). @cyanglaz do you agree?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add shared_preferences sync method
5 participants