Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Android: Added missing event.put("event", "completed"); #1470

Conversation

quentinleguennec
Copy link
Contributor

Description

On Android a call to event.put("event", "completed"); is missing, which makes it impossible to know when the video is over. This fixes it.

Related Issues

None known.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@quentinleguennec quentinleguennec changed the title Tengio video player android fixed missing completed [video_player] Android: Added missing event.put("event", "completed"); Apr 9, 2019
@quentinleguennec quentinleguennec force-pushed the tengio_video_player_android_fixed_missing_completed branch from 5902764 to 3891faa Compare April 9, 2019 11:50
@quentinleguennec
Copy link
Contributor Author

@mklim @bparrishMines Ready for review.

Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quentinleguennec, the change looks good. Once you address the merge conflicts we can land it.

@iskakaushik
Copy link
Contributor

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants