[video_player] Add platform interface #2273

cbenhagen · 2019-11-13T16:16:29Z

Description

Adds platform interface in preparation for federated plugins. Second part of this is here: #2276

Related Issues

#2041

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

cbenhagen · 2019-11-13T16:17:10Z

@hterkelsen PTAL

harryterkelsen

Thanks, Ben!

packages/video_player/video_player/pubspec.yaml

packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart

harryterkelsen · 2019-11-13T20:59:07Z

Also, I don't see anything here about the stream of VideoPlayerValues. Shouldn't that be a part of the platform interface? Otherwise all implementations will be forced to use EventChannel which is basically the same as locking them into the MethodChannelVideoPlayer platform

cbenhagen · 2019-11-13T21:10:57Z

True, I guess it should expose a stream?

Also there are some other things I am not too happy about:

the create method currently gets a Map. Would it be nicer if it would get a DataSourceDescription class?
There is a seekTo method which accepts int milliseconds. But a getPosition method which returns a Duration. What if I change seekTo to setPosition which also gets a Duration?

harryterkelsen · 2019-11-13T21:35:36Z

Yeah, I think you should expose a Stream<VideoPlayerValue>. Maybe in the platform interface you can have something like Stream<VideoPlayerValue> playerValuesFor(int textureId).

As for changing the Map parameter of create to a DataSource class, I like that idea. I see the maps as basically an implementation detail of the MethodChannel platform implementation.

I think changing seekTo to take a Duration makes sense because that maps closer to how it is called from video_player, but I don't think we need to change the name since 'seekTo' is the name of the method we call on the MethodChannel implementation

cbenhagen · 2019-11-13T22:17:13Z

Exposing a Stream<VideoEvent> would be much closer to what we have now. I will implement it this way first. Tell me if you really want me to change this to a Stream<VideoPlayerValue>.

harryterkelsen · 2019-11-13T22:48:58Z

Stream<VideoEvent> SGTM. We can let the video_player package turn those into VideoPlayerValues

cbenhagen · 2019-11-13T23:52:52Z

Stream<VideoEvent> has been added. If the tests succeed I think this could be merged and the platform interface published. Improving the create method could also be done in the second PR. Thank you very much for your help so far @hterkelsen!

packages/video_player/video_player/CHANGELOG.md

packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart

harryterkelsen

LGTM!

cbenhagen · 2019-11-14T22:13:13Z

Let's make sure we add buildView to the interface before this gets merged.

cbenhagen · 2019-11-15T11:00:48Z

Any ideas why the builds are failing now? The e2e tests are not touching anything I changed.

harryterkelsen · 2019-11-15T19:00:56Z

Yeah, very odd. It seems like some of the shards are running that same test and passing... I'll try rerunning them and see if they deflake or if there's another problem

cbenhagen · 2019-11-15T20:35:23Z

Some more of them went green. Very odd.. Can this be merged without them passing?

cbenhagen · 2019-11-20T16:41:32Z

@hterkelsen Can you restart the missing checks please? Is there anything else missing from my side to get this merged?

harryterkelsen · 2019-11-20T19:00:35Z

I restarted them. If more pass and some are still flaky I think we should still submit. I don't think this ought to block you

cbenhagen · 2019-11-20T21:49:32Z

Only 2 left. I guess it could be merged. Can you do this or do we need another review?

harryterkelsen · 2019-11-20T23:13:47Z

Sorry, I should have just merged this in earlier. It looks like there are new merge conflicts. If you resolve them and push the changes I think we can just land this.

harryterkelsen · 2019-11-20T23:15:00Z

BTW I added this tracking issue for video_player: flutter/flutter#45290

I also created this project for tracking the state of implementation for the various plugins: https://github.com/flutter/flutter/projects/69

# Conflicts: # packages/video_player/video_player/CHANGELOG.md # packages/video_player/video_player/pubspec.yaml

cbenhagen · 2019-11-21T00:22:00Z

No worries. I merged master. There haven't been any big conflicts fortunately.

harryterkelsen · 2019-11-21T00:32:43Z

Thanks! Are you able to merge? If not I can merge once the tests run (and after double checking any failures for if they are those iOS flaky tests)

cbenhagen · 2019-11-21T00:46:07Z

No I don't have write access to this repo.

cbenhagen · 2019-11-21T11:01:31Z

@hterkelsen "All checks have passed" :)

* Move plugin to subdir * Add video_player_platform_interface * Make analyzer happy * Improve documentation * Bump version and update changelog * Add stream of VideoEvent * Ignore deprecated_member_use * Improve changelog message and version * Use DataSource class * Add duration, size and buffering to VideoEvent * Seek to Duration * Fix buffering update * Adapt docstring * Add buildView

Move plugin to subdir

907efcb

cbenhagen requested review from cyanglaz and iskakaushik as code owners November 13, 2019 16:16

googlebot added the cla: yes label Nov 13, 2019

cbenhagen mentioned this pull request Nov 13, 2019

[video_player] [WIP] Add web implementation #2041

Closed

13 tasks

Add video_player_platform_interface

074afdb

cbenhagen force-pushed the video-player-platform-interface branch from f84205b to 074afdb Compare November 13, 2019 19:20

cbenhagen mentioned this pull request Nov 13, 2019

[video_player] Use platform interface #2276

Merged

13 tasks

Make analyzer happy

c80aa82

harryterkelsen reviewed Nov 13, 2019

View reviewed changes

cbenhagen added 2 commits November 13, 2019 22:22

Improve documentation

0c2ff58

Merge branch 'master' into video-player-platform-interface

3d5e425

Bump version and update changelog

2d54db2

Add stream of VideoEvent

68e9918

cbenhagen force-pushed the video-player-platform-interface branch from c37aec4 to d6b75e7 Compare November 13, 2019 23:52

Ignore deprecated_member_use

1ec7ca2

cbenhagen force-pushed the video-player-platform-interface branch from d6b75e7 to 1ec7ca2 Compare November 13, 2019 23:52

harryterkelsen reviewed Nov 13, 2019

View reviewed changes

packages/video_player/video_player/CHANGELOG.md Outdated Show resolved Hide resolved

packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart Outdated Show resolved Hide resolved

cbenhagen added 2 commits November 14, 2019 01:09

Improve changelog message and version

22f7a46

Use DataSource class

aaec591

cbenhagen requested a review from harryterkelsen November 14, 2019 09:38

cbenhagen added 2 commits November 14, 2019 12:05

Add duration, size and buffering to VideoEvent

1a12b16

Seek to Duration

ff08d85

cbenhagen added 2 commits November 14, 2019 14:58

Fix buffering update

05d3545

Adapt docstring

5dd82a1

cbenhagen mentioned this pull request Nov 14, 2019

[video_player] Add web implementation using platform interface #2279

Merged

13 tasks

harryterkelsen approved these changes Nov 14, 2019

View reviewed changes

cbenhagen added 2 commits November 15, 2019 11:11

Add buildView

4f1b1dc

Merge branch 'master' into video-player-platform-interface

693640c

Merge branch 'master' into video-player-platform-interface

40d6a6e

# Conflicts: # packages/video_player/video_player/CHANGELOG.md # packages/video_player/video_player/pubspec.yaml

harryterkelsen merged commit cba3932 into flutter:master Nov 21, 2019

[video_player] Add platform interface #2273

[video_player] Add platform interface #2273

Uh oh!

Conversation

cbenhagen commented Nov 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Checklist

Breaking Change

Uh oh!

cbenhagen commented Nov 13, 2019

Uh oh!

harryterkelsen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

harryterkelsen commented Nov 13, 2019

Uh oh!

cbenhagen commented Nov 13, 2019

Uh oh!

harryterkelsen commented Nov 13, 2019

Uh oh!

cbenhagen commented Nov 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

harryterkelsen commented Nov 13, 2019

Uh oh!

cbenhagen commented Nov 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

harryterkelsen left a comment

Choose a reason for hiding this comment

Uh oh!

cbenhagen commented Nov 14, 2019

Uh oh!

cbenhagen commented Nov 15, 2019

Uh oh!

harryterkelsen commented Nov 15, 2019

Uh oh!

cbenhagen commented Nov 15, 2019

Uh oh!

cbenhagen commented Nov 20, 2019

Uh oh!

harryterkelsen commented Nov 20, 2019

Uh oh!

cbenhagen commented Nov 20, 2019

Uh oh!

harryterkelsen commented Nov 20, 2019

Uh oh!

harryterkelsen commented Nov 20, 2019

Uh oh!

cbenhagen commented Nov 21, 2019

Uh oh!

harryterkelsen commented Nov 21, 2019

Uh oh!

cbenhagen commented Nov 21, 2019

Uh oh!

cbenhagen commented Nov 21, 2019

Uh oh!

Uh oh!

cbenhagen commented Nov 13, 2019 •

edited

Loading

cbenhagen commented Nov 13, 2019 •

edited

Loading

cbenhagen commented Nov 13, 2019 •

edited

Loading