-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[video_player] Add platform interface #2273
[video_player] Add platform interface #2273
Conversation
@hterkelsen PTAL |
f84205b
to
074afdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Ben!
packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart
Outdated
Show resolved
Hide resolved
packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart
Outdated
Show resolved
Hide resolved
Also, I don't see anything here about the stream of |
True, I guess it should expose a stream? Also there are some other things I am not too happy about:
|
Yeah, I think you should expose a As for changing the I think changing |
Exposing a |
|
c37aec4
to
d6b75e7
Compare
d6b75e7
to
1ec7ca2
Compare
|
packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Let's make sure we add |
Any ideas why the builds are failing now? The e2e tests are not touching anything I changed. |
Yeah, very odd. It seems like some of the shards are running that same test and passing... I'll try rerunning them and see if they deflake or if there's another problem |
Some more of them went green. Very odd.. Can this be merged without them passing? |
@hterkelsen Can you restart the missing checks please? Is there anything else missing from my side to get this merged? |
I restarted them. If more pass and some are still flaky I think we should still submit. I don't think this ought to block you |
Only 2 left. I guess it could be merged. Can you do this or do we need another review? |
Sorry, I should have just merged this in earlier. It looks like there are new merge conflicts. If you resolve them and push the changes I think we can just land this. |
BTW I added this tracking issue for I also created this project for tracking the state of implementation for the various plugins: https://github.com/flutter/flutter/projects/69 |
# Conflicts: # packages/video_player/video_player/CHANGELOG.md # packages/video_player/video_player/pubspec.yaml
No worries. I merged master. There haven't been any big conflicts fortunately. |
Thanks! Are you able to merge? If not I can merge once the tests run (and after double checking any failures for if they are those iOS flaky tests) |
No I don't have write access to this repo. |
@hterkelsen "All checks have passed" :) |
* Move plugin to subdir * Add video_player_platform_interface * Make analyzer happy * Improve documentation * Bump version and update changelog * Add stream of VideoEvent * Ignore deprecated_member_use * Improve changelog message and version * Use DataSource class * Add duration, size and buffering to VideoEvent * Seek to Duration * Fix buffering update * Adapt docstring * Add buildView
Description
Adds platform interface in preparation for federated plugins. Second part of this is here: #2276
Related Issues
#2041
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?