Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Implement shared_preferences on top of platform interface #2325

Merged
merged 6 commits into from
Nov 27, 2019

Conversation

yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Nov 27, 2019

Description

  • Implement shared_preferences on top of package:shared_preferences_platform_interface.
  • Remove analysis options exemption and fix analysis errors (mostly unawaited futures).

Related Issues

Fixes flutter/flutter#45627
Next step towards flutter/flutter#35116

@yjbanov yjbanov force-pushed the web-shared-preferences-3 branch from 37175b2 to a76548a Compare November 27, 2019 19:23
@yjbanov yjbanov changed the title WIP: Implement shared_preferences on top of platform interface Implement shared_preferences on top of platform interface Nov 27, 2019
@yjbanov yjbanov removed the WIP label Nov 27, 2019
@yjbanov
Copy link
Contributor Author

yjbanov commented Nov 27, 2019

This is ready to go now.

@yjbanov
Copy link
Contributor Author

yjbanov commented Nov 27, 2019

As in, ready for review :)

@yjbanov yjbanov merged commit 7af9a1a into flutter:master Nov 27, 2019
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
* implement shared_preferences on top of platform interface
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shared_preferences_platform_interface isn't being linted correctly
3 participants