-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Conversation
baseUrl: "file://"+path+"/"
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it!
…On Sat, May 2, 2020 at 6:20 PM googlebot ***@***.***> wrote:
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed (or fixed any issues), please reply here with @googlebot
I signed it! and we'll verify it.
------------------------------
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
- Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version <https://opensource.google/docs/cla/#troubleshoot>).
- The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- The email used to register you as an authorized contributor must
also be attached to your GitHub account
<https://github.com/settings/emails>.
ℹ️ *Googlers: Go here
<https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fflutter%2Fplugins%2Fpull%2F2730>
for more info*.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2730 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGEY5CDQFCB4PC4BOCV2WR3RPQJH3ANCNFSM4MXVNM2Q>
.
--
--
*Thanks & Regards*
*Akshay Pauranik <[email protected]>*
*uCertify *
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This doesn't seems to be an issue of the code. I have futher investigated and found that there is some issue with the test setAndGetScrollPosition testcase. It produces random results and hence fails, this may be due to slow loading of webview or something else. But actually my PR is not related to it at all. Please help me. Below is the video of the issue. |
Description
This is an enhancement of the current implementation of flutter webview. This addresses the issue of loading static html in webview, alongwith baseUrl support. This works in both ios and android.
Related Issues
Earlier we used to do it through initialUrl, by converting it to base64 string and so on. React native has a proper support for static html and baseUrl.(fluttercommunity/flutter_webview_plugin#23)
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?