Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

local html and baseUrl support #2730

Closed
wants to merge 18 commits into from
Closed

Conversation

uc-apa
Copy link

@uc-apa uc-apa commented May 2, 2020

Description

This is an enhancement of the current implementation of flutter webview. This addresses the issue of loading static html in webview, alongwith baseUrl support. This works in both ios and android.

Related Issues

Earlier we used to do it through initialUrl, by converting it to base64 string and so on. React native has a proper support for static html and baseUrl.(fluttercommunity/flutter_webview_plugin#23)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@uc-apa
Copy link
Author

uc-apa commented May 3, 2020 via email

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels May 3, 2020
@uc-apa
Copy link
Author

uc-apa commented May 7, 2020

This doesn't seems to be an issue of the code. I have futher investigated and found that there is some issue with the test setAndGetScrollPosition testcase. It produces random results and hence fails, this may be due to slow loading of webview or something else. But actually my PR is not related to it at all. Please help me. Below is the video of the issue.

Video

@uc-apa uc-apa closed this Jul 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants