Revert "[path_provider] Use the application ID in the application support path"

[dnfield]

Reverts #2845

This broke master - Linux is consistently timing out after this.

TBR @robert-ancell @stuartmorgan

/cc @ditman

[dnfield]

I will wait for the test that's been timing out to pass before merging this.

[ditman]

path_provider_linux 0.1.0 seems to NOT have been published yet, so this looks safe to land (then reland the fixed 0.1.0).

(Note, this change may fail the publishable check, because it's not rolling forward the version of the package that it's "modifying" with what's published in pub.)

Yep:

packages/path_provider/path_provider_linux/pubspec.yaml incorrectly updated version.
HEAD: 0.0.1+2, master: 0.1.0.
Allowed versions: {1.0.0: NextVersionType.RELEASE, 0.2.0: NextVersionType.BREAKING_MAJOR, 0.1.1: NextVersionType.MINOR, 0.1.0+1: NextVersionType.PATCH

[dnfield]

Hm. I'm not sure if this will make the version check permanently angry?

[ditman]

You may be able to "revert" to 0.1.0+1 (with a CHANGELOG entry), then the original code can be re-landed as 0.2.0?

[dnfield]

That seems pretty wrong to me - we'd never want to publish those versions, and users are likely to get confused when reading the CHANGELOG :\

[ditman]

@dnfield when we publish the 0.2.0 we can erase all mentions to 0.1.x changelog, as if this never happened :P

[ditman]

Go for this! Maybe get an ACK from Stuart that this is being reverted?

[dnfield]

Given that this has broken the tree, going to land - we can always reland it when it's ready.

[stuartmorgan-g]

Go for this! Maybe get an ACK from Stuart that this is being reverted?

Noted. I'm actually not sure the PR should have landed before flutter/flutter#60053 anyway.

[robert-ancell]

Noted. I'm actually not sure the PR should have landed before flutter/flutter#60053 anyway.

This change is only supposed to work if an application ID is set, and reverts to the old behaviour if not, so the PRs are independent.

[robert-ancell]

@dnfield do you have a link to the log of the failure?

[dnfield]

https://cirrus-ci.com/task/6312004510023680