Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Clarify e2e readme for running on firebase test lab #2898

Merged
merged 3 commits into from
Jul 29, 2020

Conversation

CareF
Copy link
Contributor

@CareF CareF commented Jul 25, 2020

Description

A few lines update to readme about how to run e2e tests on firebase test lab.

Update for kotlin is still a to-do.

Related Issues

N/A

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@CareF CareF requested a review from dnfield July 25, 2020 03:58
@CareF CareF requested a review from digiter as a code owner July 25, 2020 03:58
@CareF CareF self-assigned this Jul 25, 2020
pushd android
flutter build apk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is to set the desired runtime mode?

If so we should explain that. If not we should explain why we're doing this

Copy link
Contributor Author

@CareF CareF Jul 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this set the runtime mode. This routine still uploads debug app (which I still need to figure out how to get a release/profile testing app), but flutter build generates some files and directories, e.g. ./gradlew. I'm not sure if there's anything else.

@CareF CareF requested a review from dnfield July 25, 2020 04:19
@CareF
Copy link
Contributor Author

CareF commented Jul 29, 2020

@dnfield PTAL

@CareF CareF merged commit f6660a9 into flutter:master Jul 29, 2020
@CareF CareF deleted the e2e_readme branch July 29, 2020 18:53
jarrodcolburn pushed a commit to jarrodcolburn/plugins that referenced this pull request Aug 20, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants