Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Call platform.dispose on GoogleMap widget dispose. #2909

Merged
merged 6 commits into from
Aug 12, 2020

Conversation

ditman
Copy link
Member

@ditman ditman commented Aug 7, 2020

Description

This change uses the dispose method introduced in #2908, and calls it on dispose of the GoogleMap widget. This allows the plugin to cleanup resources once the framework is done with the widget rendering the map.

(Note: this PR will fail until the one above lands!)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@ditman ditman changed the title [core] Call platform.dispose when on Widget dispose. [google_maps_flutter] Call platform.dispose when on Widget dispose. Aug 7, 2020
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ditman ditman changed the title [google_maps_flutter] Call platform.dispose when on Widget dispose. [google_maps_flutter] Call platform.dispose on GoogleMap widget dispose. Aug 12, 2020
@ditman ditman merged commit 0d5dd3a into flutter:master Aug 12, 2020
@ditman ditman deleted the gmaps-use-dispose branch August 12, 2020 17:19
jarrodcolburn pushed a commit to jarrodcolburn/plugins that referenced this pull request Aug 20, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants