Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[e2e] revert performance tracker utilities #2917

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

CareF
Copy link
Contributor

@CareF CareF commented Aug 10, 2020

Description

This is reverting part of #2906 to fix the breaking build, as another solution to #2914.
Dependence of FrameTiming is not appropriate in e2e now because FrameTiming API is still evolving and e2e needs to be compatible with the stable version of the engine and the framework.

Related Issues

flutter/engine#20229

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@CareF CareF requested review from ditman, dnfield and liyuqian August 10, 2020 22:05
@CareF CareF requested a review from digiter as a code owner August 10, 2020 22:05
Copy link

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this, it should bring the tree back to green (or closer to what it is now :P)

@ditman ditman merged commit 3ae30be into flutter:master Aug 11, 2020
@CareF CareF deleted the revert_end_perf branch August 11, 2020 18:02
jarrodcolburn pushed a commit to jarrodcolburn/plugins that referenced this pull request Aug 20, 2020
@CareF CareF mentioned this pull request Oct 6, 2020
13 tasks
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants