Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[device_info] Platform interface added in device_info #2929

Merged
merged 5 commits into from
Aug 18, 2020
Merged

[device_info] Platform interface added in device_info #2929

merged 5 commits into from
Aug 18, 2020

Conversation

yash1200
Copy link
Contributor

@yash1200 yash1200 commented Aug 13, 2020 •
edited
Loading

Description

In this PR, I have added platform interface package to the device_info plugin.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@yash1200
Copy link
Contributor Author

@ditman Hey! why does this PR has no reviewer assigned ?

@ditman
Copy link
Member

ditman commented Aug 13, 2020

@yash1200 I don't know, it should have picked up stuff from the owners file. I can review this.

@ditman ditman self-requested a review August 13, 2020 21:39
@yash1200
Copy link
Contributor Author

Thanks for requesting a review! :)

ditman
ditman suggested changes Aug 14, 2020
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move some more code from the core of the plugin to this package?

ditman
ditman suggested changes Aug 14, 2020
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is almost ready to go. Can you add a couple of tests for the public methods of the MethodChannelDeviceInfo class? (I've linked an example on how to override MethodChannel responses.)

@yash1200
Copy link
Contributor Author

All the changes are done now.

@ditman
Copy link
Member

ditman commented Aug 16, 2020

Looks good, I'll merge this on Monday!

@yash1200
Copy link
Contributor Author

Thank you Sir! :)

@ditman
Add copyright notices to dart files.
d79cfe1 
Fix naming of model files.

Make method_channel implementation "private" to this package.

Ensure core package exports needed types.
@ditman
Copy link
Member

ditman commented Aug 17, 2020

Hey @yash1200 I pushed a couple of changes to your branch directly, I hope you don't mind (was trying to send you a PR but I couldn't). It's mostly adding copyright notices to files and moving files around so they're not exposed normally. I forgot to comment on those in earlier PRs, and didn't want to bother you again.

Please, take a look at my latest push and see if it makes sense!

@yash1200
Copy link
Contributor Author

Yeah, looks good to me 💯

@ditman
Copy link
Member

ditman commented Aug 17, 2020

I'll merge this once the tests in master pass.

@yash1200
Copy link
Contributor Author

Thank You again ! :)

@ditman ditman self-requested a review August 18, 2020 17:27
ditman
ditman approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this one!

@ditman ditman merged commit e3ffd87 into flutter:master Aug 18, 2020
@yash1200
Copy link
Contributor Author

yash1200 commented Aug 18, 2020 •
edited
Loading

Thanks for the help! Just one last query, how can I request a review in a PR. I can't find any option to request as it is stated here.

@ditman
Copy link
Member

ditman commented Aug 18, 2020

@yash1200 there should be a "Reviewers" section in the top-right corner of the PR, where you can add people. If not, make sure you mention (@ditman) the people who needs to be aware of the PR.

@ditman
Copy link
Member

ditman commented Aug 18, 2020 •
edited
Loading

@yash1200 This package has been published, you should be able to use from your pubspec normally:

https://pub.dev/packages/device_info_platform_interface

@yash1200
Copy link
Contributor Author

Thanks @ditman .

@yash1200 yash1200 deleted the yash_device_info branch August 18, 2020 19:00
jarrodcolburn pushed a commit to jarrodcolburn/plugins that referenced this pull request Aug 20, 2020
@yash1200 @jarrodcolburn
[device_info_platform_interface] Introduce package (flutter#2929)
570ffd6 
This is the platform interface package of the federated device_info plugin.
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
@yash1200 @jorgefspereira
[device_info_platform_interface] Introduce package (flutter#2929)
4c87c5b 
This is the platform interface package of the federated device_info plugin.
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
@yash1200
[device_info_platform_interface] Introduce package (flutter#2929)
e2b27c1 
This is the platform interface package of the federated device_info plugin.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ditman ditman ditman approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yash1200 @ditman @googlebot