[google_maps_flutter_web] First version of the plugin. #2933

ditman · 2020-08-16T05:14:58Z

Description

This is the first version of the Google Maps plugin for web, started by @cylyl, and finished by myself.

There are some missing features that were Android only, but I think I documented most of them in the README of the plugin.

Testing

If you want to manually test this plugin, I've published the standard maps example app here:

https://dit-maps-tests.web.app

There's a good amount of unit tests in this PR. They need chromedriver to run. See the README of the test directory on how to run them. Here's more information: An introduction to integration testing.

If anybody wants to test this branch into their App, use a Git dependency on the pubspec file, like so:

google_maps_flutter_web:
  git:
    url: https://github.com/ditman/plugins.git
    ref: gmaps-web
    path: packages/google_maps_flutter/google_maps_flutter_web

Then compile your app for the web. Get started here: Building a web application with Flutter.

Related Issues

[google_maps_flutter] Support google_maps_flutter on web flutter#45292

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

No, this is not a breaking change.

googlebot · 2020-08-16T05:16:00Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

cylyl · 2020-08-16T07:35:34Z

@googlebot I consent.

googlebot · 2020-08-16T07:37:10Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

jfreeland · 2020-08-17T18:40:08Z

If anybody wants to test this branch into their App, use a Git dependency on the pubspec file, like so:
google_maps_for_web:

nit: I think should be google_maps_flutter_web for anyone reading and it's not obvious? Though I suppose you could make both work.

And is it strictly required that I be using your version of google_maps_flutter as well? I haven't read through the PR to see if there were any meaningful changes, but I have been using your repo more-or-less in this manner:

  google_maps_flutter:
    git:
      url: https://github.com/ditman/plugins.git
      ref: gmaps-web
      path: packages/google_maps_flutter/google_maps_flutter
  google_maps_flutter_web:
    git:
      url: https://github.com/ditman/plugins.git
      ref: gmaps-web
      path: packages/google_maps_flutter/google_maps_flutter_web

It seems like you have a strict dependency on google_maps_flutter from .., so perhaps my declaring this is redundant and not necessary.

ditman · 2020-08-17T18:55:56Z

@jfreeland you're right! I don't even know the name of the package anymore, I've fixed the instructions in the PR.

I have published all the changes to other packages, so as long as you have google_maps_flutter: 0.5.30 and google_maps_flutter_platform_interface: 1.0.4 (latest published), you should only need to add the git dependency on the web package (check your pubspec.lock for the versions that you're currently using!).

packages/google_maps_flutter/google_maps_flutter_web/README.md

packages/google_maps_flutter/google_maps_flutter_web/lib/src/circle.dart

packages/google_maps_flutter/google_maps_flutter_web/lib/src/marker.dart

packages/google_maps_flutter/google_maps_flutter_web/lib/src/markers.dart

packages/google_maps_flutter/google_maps_flutter_web/lib/src/polygon.dart

implement : * tab * long press * moveCamera * getVisibleRegion * getScreenCoordinate * getLatLng * getZoomLevel

…le click.

…ller methods.

* Sanitize title/content to prevent XSS * Open InfoWindow automatically on marker click * Do not render infoWindow if it's empty * Update contents of infoWindow alongside its Marker

…roller. Substitute direct access by semantic methods. Use those methods in the platform implementation instead.

… Maps Controller.

…able dispose method.

…o the GoogleMapController.

* Add a few changes to the controller to allow for overrides when testing. * Make some conversion functions more null-resilient. * Fix some inconsistencies in some conversion function naming.

Also: * Add copyright notices to dart files * Add analysis_options.yaml file * Tweak build all script to let it know this package has its own analysis_options file. * Extract some types that were randomly strawn around the code to a types.dart file.

ditman · 2020-08-18T22:04:06Z

(Rebased to get the latest changes to the build scripts from master.)

cyanglaz

LGTM

ditman · 2020-08-19T04:11:33Z

This has been published and tagged as v0.1.0:

https://pub.dev/packages/google_maps_flutter_web

This package introduces the first version of the google_maps_flutter_web plugin. See README for installation instructions. Co-authored-by: chung2012 <[email protected]>

ditman requested a review from cyanglaz August 16, 2020 05:14

googlebot added the cla: no label Aug 16, 2020

ditman force-pushed the gmaps-web branch from f4f478c to e0ff184 Compare August 16, 2020 05:23

googlebot added cla: yes and removed cla: no labels Aug 16, 2020

cyanglaz reviewed Aug 17, 2020

View reviewed changes

cylyl and others added 19 commits August 18, 2020 15:03

Partially implement google_maps_flutter_web

d2e53de

default loc;

b397672

buildView document

239b8c9

Circle

0e980a5

onCircleTap

188c8dd

Marker events

7ec2505

refactor convert function

266f473

implement : * tab * long press * moveCamera * getVisibleRegion * getScreenCoordinate * getLatLng * getZoomLevel

updateMapOptions

e95425c

setMapStyle

9ce8771

update pubspec

d03b83f

Repo surgery

f990aae

Use creationMapId as a cache key in the buildView method.

c16b730

Broadcast Camera Move event.

ba3113d

Add CameraMoveStartedEvent, CameraIdleEvent. Remove LongPress on doub…

687687c

…le click.

Make controllers emit their own events instead of calling maps contro…

dd7be6f

…ller methods.

ontab -> onTap

c52a301

Support custom marker images from Assets.

b78bafa

Implement moveCamera

74f9b5a

Fix some analyzer issues.

eadc5cd

ditman added 19 commits August 18, 2020 15:03

Some formatting/analyzer fixes.

e5d91e1

Test MarkersController infoWindow open/close

8520de3

Format and test the rest of the shapes.

1536ea6

Apply BOTH size and scaledSize properties to custom markers

f5e5433

Check if the size has actually been passed from the plugin.

9fcb61d

Add traffic layer support, when creating the map, and toggling options.

fe950ac

Add InfoWindow support.

deca0eb

* Sanitize title/content to prevent XSS * Open InfoWindow automatically on marker click * Do not render infoWindow if it's empty * Update contents of infoWindow alongside its Marker

Hide most of the directly accessible properties in the GoogleMap Cont…

74fff64

…roller. Substitute direct access by semantic methods. Use those methods in the platform implementation instead.

Add e2e to dev_deps so the package becomes publishable

825eff8

Make flutter analyze happy again.

de87fee

some of the infoWindow content may be null.

9f9a6df

Do not share the StreamController across mapIds.

8dd132c

Do not cache the StreamController in the Plugin, leave it only in the…

a1fe1d7

… Maps Controller.

Update minimum platform_interface version to 1.0.4 to have an overrid…

941e511

…able dispose method.

Remove all 'options' handling from the plugin implementation, and int…

cb7a793

…o the GoogleMapController.

Add tests for GoogleMapsPlugin class.

ac1d09a

Add tests for google_maps_controller.dart

b059196

* Add a few changes to the controller to allow for overrides when testing. * Make some conversion functions more null-resilient. * Fix some inconsistencies in some conversion function naming.

Address PR comments.

5eaeb9e

Also: * Add copyright notices to dart files * Add analysis_options.yaml file * Tweak build all script to let it know this package has its own analysis_options file. * Extract some types that were randomly strawn around the code to a types.dart file.

backtick the onTap mention in the CircleController class.

7292a65

ditman force-pushed the gmaps-web branch from be02a02 to 7292a65 Compare August 18, 2020 22:03

ditman requested a review from cyanglaz August 18, 2020 22:04

cyanglaz approved these changes Aug 19, 2020

View reviewed changes

ditman merged commit 027827f into flutter:master Aug 19, 2020

ditman deleted the gmaps-web branch August 25, 2020 22:02

johnpryan mentioned this pull request Sep 22, 2020

Add web support to place_tracker flutter/samples#550

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[google_maps_flutter_web] First version of the plugin. #2933

[google_maps_flutter_web] First version of the plugin. #2933

Uh oh!

ditman commented Aug 16, 2020 •

edited

Loading

Uh oh!

googlebot commented Aug 16, 2020

Uh oh!

cylyl commented Aug 16, 2020

Uh oh!

googlebot commented Aug 16, 2020

Uh oh!

jfreeland commented Aug 17, 2020 •

edited

Loading

Uh oh!

ditman commented Aug 17, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ditman commented Aug 18, 2020

Uh oh!

cyanglaz left a comment

Uh oh!

ditman commented Aug 19, 2020

Uh oh!

Uh oh!

[google_maps_flutter_web] First version of the plugin. #2933

[google_maps_flutter_web] First version of the plugin. #2933

Uh oh!

Conversation

ditman commented Aug 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Related Issues

Checklist

Breaking Change

Uh oh!

googlebot commented Aug 16, 2020

Uh oh!

cylyl commented Aug 16, 2020

Uh oh!

googlebot commented Aug 16, 2020

Uh oh!

jfreeland commented Aug 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ditman commented Aug 17, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ditman commented Aug 18, 2020

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

ditman commented Aug 19, 2020

Uh oh!

Uh oh!

ditman commented Aug 16, 2020 •

edited

Loading

jfreeland commented Aug 17, 2020 •

edited

Loading