-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[camera] Move camera to camera/camera #3258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Can you please update the pubspec.yaml of the plugin with a patch bump of the version, and the new homepage?
version: 0.5.8+15
homepage: https://github.com/flutter/plugins/tree/master/packages/camera/camera
Also add an entry to the changelog describing the change? Something like:
"Moved package to camera/camera
subdir, to allow for federated implementations."
This way we can republish camera/camera to pub.dev, and others with in-flight PRs will understand why we did the move.
Thanks!!
8a361ba
to
2f2aa20
Compare
@ditman, thank you for reviewing. I have processed your feedback and would appreciate it if you could give another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you need to modify camera
by camera/camera
in this line:
https://github.com/flutter/plugins/blob/master/.cirrus.yml#L166
For tests to pass, otherwise this LGTM.
* Move camera to camera/camera * Fix relative path after move * Rebased with master and update version * Update homepage * Skip XCTESTS for the camera/camera plugin
* Move camera to camera/camera * Fix relative path after move * Rebased with master and update version * Update homepage * Skip XCTESTS for the camera/camera plugin
Description
This pull request prepares the camera plugin for federation by simply moving all current logic into it's own "camera" folder. A suggested by @ditman in the PR #3253 (see #3253 (comment)).
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?