Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[wifi_info_flutter] Migrate to null safety #3425

Merged
merged 9 commits into from
Feb 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/wifi_info_flutter/wifi_info_flutter/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.0.0-nullsafety

* Migrate to null safety.

## 1.0.4

* Android: Add Log warning for unsatisfied requirement(s) in Android P or higher.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// @dart = 2.9

import 'dart:io';
import 'package:integration_test/integration_test.dart';
import 'package:flutter_test/flutter_test.dart';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,14 @@ export 'package:wifi_info_flutter_platform_interface/wifi_info_flutter_platform_

/// Checks WI-FI status and more.
class WifiInfo {
WifiInfo._();

/// Constructs a singleton instance of [WifiInfo].
///
/// [WifiInfo] is designed to work as a singleton.
factory WifiInfo() {
if (_singleton == null) {
_singleton = WifiInfo._();
}
return _singleton;
}

WifiInfo._();
factory WifiInfo() => _singleton;

static WifiInfo _singleton;
static final WifiInfo _singleton = WifiInfo._();

static WifiInfoFlutterPlatform get _platform =>
WifiInfoFlutterPlatform.instance;
Expand All @@ -36,7 +31,7 @@ class WifiInfo {
///
/// From android 8.0 onwards the GPS must be ON (high accuracy)
/// in order to be able to obtain the SSID.
Future<String> getWifiName() {
Future<String?> getWifiName() {
return _platform.getWifiName();
}

Expand All @@ -46,12 +41,12 @@ class WifiInfo {
///
/// From Android 8.0 onwards the GPS must be ON (high accuracy)
/// in order to be able to obtain the BSSID.
Future<String> getWifiBSSID() {
Future<String?> getWifiBSSID() {
return _platform.getWifiBSSID();
}

/// Obtains the IP address of the connected wifi network
Future<String> getWifiIP() {
Future<String?> getWifiIP() {
return _platform.getWifiIP();
}

Expand Down
8 changes: 3 additions & 5 deletions packages/wifi_info_flutter/wifi_info_flutter/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
name: wifi_info_flutter
description: A new flutter plugin project.
version: 1.0.4
version: 2.0.0-nullsafety
homepage: https://github.com/flutter/plugins/tree/master/packages/wifi_info_flutter/wifi_info_flutter

environment:
sdk: ">=2.7.0 <3.0.0"
sdk: ">=2.12.0-0 <3.0.0"
flutter: ">=1.20.0"

dependencies:
flutter:
sdk: flutter
wifi_info_flutter_platform_interface: ^1.0.0
wifi_info_flutter_platform_interface: ^2.0.0-nullsafety

dev_dependencies:
mockito: ^4.1.1
plugin_platform_interface: ^1.0.0
integration_test:
path: ../../integration_test
flutter_test:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// @dart = 2.8

import 'package:wifi_info_flutter/wifi_info_flutter.dart';
import 'package:wifi_info_flutter_platform_interface/wifi_info_flutter_platform_interface.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:plugin_platform_interface/plugin_platform_interface.dart';
import 'package:mockito/mockito.dart';

const String kWifiNameResult = '1337wifi';
const String kWifiBSSIDResult = 'c0:ff:33:c0:d3:55';
Expand All @@ -20,7 +16,7 @@ const LocationAuthorizationStatus kGetLocationResult =

void main() {
group('$WifiInfo', () {
WifiInfo wifiInfo;
late WifiInfo wifiInfo;
MockWifiInfoFlutterPlatform fakePlatform;

setUp(() async {
Expand All @@ -30,17 +26,17 @@ void main() {
});

test('getWifiName', () async {
String result = await wifiInfo.getWifiName();
String? result = await wifiInfo.getWifiName();
expect(result, kWifiNameResult);
});

test('getWifiBSSID', () async {
String result = await wifiInfo.getWifiBSSID();
String? result = await wifiInfo.getWifiBSSID();
expect(result, kWifiBSSIDResult);
});

test('getWifiIP', () async {
String result = await wifiInfo.getWifiIP();
String? result = await wifiInfo.getWifiIP();
expect(result, kWifiIpAddressResult);
});

Expand All @@ -58,27 +54,30 @@ void main() {
});
}

class MockWifiInfoFlutterPlatform extends Mock
with MockPlatformInterfaceMixin
implements WifiInfoFlutterPlatform {
Future<String> getWifiName() async {
class MockWifiInfoFlutterPlatform extends WifiInfoFlutterPlatform {
@override
Future<String?> getWifiName() async {
return kWifiNameResult;
}

Future<String> getWifiBSSID() async {
@override
Future<String?> getWifiBSSID() async {
return kWifiBSSIDResult;
}

Future<String> getWifiIP() async {
@override
Future<String?> getWifiIP() async {
return kWifiIpAddressResult;
}

@override
Future<LocationAuthorizationStatus> requestLocationServiceAuthorization({
bool requestAlwaysLocationUsage = false,
}) async {
return kRequestLocationResult;
}

@override
Future<LocationAuthorizationStatus> getLocationServiceAuthorization() async {
return kGetLocationResult;
}
Expand Down